Allow deleting autofill password suggestions on Shift+Delete

chrome/browser/password_manager/password_manager.cc

Index: chrome/browser/password_manager/password_manager.cc
diff --git a/chrome/browser/password_manager/password_manager.cc b/chrome/browser/password_manager/password_manager.cc
index 80392991c52f996d95743a3daab91cdd69e6fb07..8edb78efd9a73eea3d5c0d77f51585e64db93bf1 100644
--- a/chrome/browser/password_manager/password_manager.cc
+++ b/chrome/browser/password_manager/password_manager.cc
@@ -14,6 +14,8 @@
 #include "chrome/browser/password_manager/password_form_manager.h"
 #include "chrome/browser/password_manager/password_manager_delegate.h"
 #include "chrome/browser/password_manager/password_manager_metrics_util.h"
+#include "chrome/browser/password_manager/password_store.h"
+#include "chrome/browser/password_manager/password_store_factory.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller.h"
 #include "chrome/common/chrome_switches.h"
@@ -263,6 +265,8 @@ bool PasswordManager::OnMessageReceived(const IPC::Message& message) {
                         OnPasswordFormsRendered)
     IPC_MESSAGE_HANDLER(AutofillHostMsg_PasswordFormSubmitted,
                         OnPasswordFormSubmitted)
+    IPC_MESSAGE_HANDLER(AutofillHostMsg_RemovePasswordSuggestion,
+                        OnRemovePasswordSuggestion)
     IPC_MESSAGE_UNHANDLED(handled = false)
   IPC_END_MESSAGE_MAP()
   return handled;
@@ -352,6 +356,19 @@ void PasswordManager::OnPasswordFormsRendered(
   }
 }
 
+void PasswordManager::OnRemovePasswordSuggestion(
+    const PasswordForm& password_form) {
+  scoped_refptr<PasswordStore> password_store =
+      PasswordStoreFactory::GetForProfile(delegate_->GetProfile(),
+                                          Profile::EXPLICIT_ACCESS);

[vabr (Chromium), 2014/02/05 20:34:20]

nit: Add a comment that we use EXPLICIT_ACCESS because removing passwords is
allowed in Incognito profiles.

+
+  ManagePasswordsBubbleUIController* manage_passwords_bubble_ui_controller =
+      ManagePasswordsBubbleUIController::FromWebContents(web_contents());
+  if (manage_passwords_bubble_ui_controller)
+    manage_passwords_bubble_ui_controller->RemoveFromBestMatches(password_form);
+  password_store->RemoveLogin(password_form);
+}
+
 void PasswordManager::PossiblyInitializeUsernamesExperiment(
     const PasswordFormMap& best_matches) const {
   if (base::FieldTrialList::Find(kOtherPossibleUsernamesExperiment))