Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Unified Diff: chrome/browser/password_manager/password_manager.cc

Issue 133893004: Allow deleting autofill password suggestions on Shift+Delete (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Allow Password autofill suggestions deletion Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/password_manager.cc
diff --git a/chrome/browser/password_manager/password_manager.cc b/chrome/browser/password_manager/password_manager.cc
index 80392991c52f996d95743a3daab91cdd69e6fb07..8edb78efd9a73eea3d5c0d77f51585e64db93bf1 100644
--- a/chrome/browser/password_manager/password_manager.cc
+++ b/chrome/browser/password_manager/password_manager.cc
@@ -14,6 +14,8 @@
#include "chrome/browser/password_manager/password_form_manager.h"
#include "chrome/browser/password_manager/password_manager_delegate.h"
#include "chrome/browser/password_manager/password_manager_metrics_util.h"
+#include "chrome/browser/password_manager/password_store.h"
+#include "chrome/browser/password_manager/password_store_factory.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller.h"
#include "chrome/common/chrome_switches.h"
@@ -263,6 +265,8 @@ bool PasswordManager::OnMessageReceived(const IPC::Message& message) {
OnPasswordFormsRendered)
IPC_MESSAGE_HANDLER(AutofillHostMsg_PasswordFormSubmitted,
OnPasswordFormSubmitted)
+ IPC_MESSAGE_HANDLER(AutofillHostMsg_RemovePasswordSuggestion,
+ OnRemovePasswordSuggestion)
IPC_MESSAGE_UNHANDLED(handled = false)
IPC_END_MESSAGE_MAP()
return handled;
@@ -352,6 +356,19 @@ void PasswordManager::OnPasswordFormsRendered(
}
}
+void PasswordManager::OnRemovePasswordSuggestion(
+ const PasswordForm& password_form) {
+ scoped_refptr<PasswordStore> password_store =
+ PasswordStoreFactory::GetForProfile(delegate_->GetProfile(),
+ Profile::EXPLICIT_ACCESS);
+
+ ManagePasswordsBubbleUIController* manage_passwords_bubble_ui_controller =
+ ManagePasswordsBubbleUIController::FromWebContents(web_contents());
+ if (manage_passwords_bubble_ui_controller)
+ manage_passwords_bubble_ui_controller->RemoveFromBestMatches(password_form);
+ password_store->RemoveLogin(password_form);
+}
+
void PasswordManager::PossiblyInitializeUsernamesExperiment(
const PasswordFormMap& best_matches) const {
if (base::FieldTrialList::Find(kOtherPossibleUsernamesExperiment))

Powered by Google App Engine
This is Rietveld 408576698