components/autofill/core/browser/test_autofill_external_delegate.cc - Issue 133893004: Allow deleting autofill password suggestions on Shift+Delete

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/test_autofill_external_delegate.cc

Issue 133893004: Allow deleting autofill password suggestions on Shift+Delete (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments addressed Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/core/browser/password_autofill_manager.cc ('K') | « components/autofill/core/browser/password_autofill_manager.cc ('k') | components/autofill/core/common/autofill_messages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/test_autofill_external_delegate.cc

diff --git a/components/autofill/core/browser/test_autofill_external_delegate.cc b/components/autofill/core/browser/test_autofill_external_delegate.cc

index 94e6b9ec8bc72bdc8be2c8dc36a778ab73aa159e..0370a86c9c11ead71bcc70b8fdd5f98f7e5b0345 100644

--- a/components/autofill/core/browser/test_autofill_external_delegate.cc

+++ b/components/autofill/core/browser/test_autofill_external_delegate.cc

@@ -16,7 +16,9 @@ void GenerateTestAutofillPopup(

field.is_focusable = true;

field.should_autocomplete = true;

gfx::RectF bounds(100.f, 100.f);

- autofill_external_delegate->OnQuery(query_id, form, field, bounds, false);

+ PasswordForm password_form;

+ autofill_external_delegate->OnQuery(

+ query_id, form, field, password_form, bounds, false);

std::vector<base::string16> autofill_item;

autofill_item.push_back(base::string16());