Allow deleting autofill password suggestions on Shift+Delete

components/autofill/core/browser/autofill_external_delegate.h

Index: components/autofill/core/browser/autofill_external_delegate.h
diff --git a/components/autofill/core/browser/autofill_external_delegate.h b/components/autofill/core/browser/autofill_external_delegate.h
index 6f3f4d7067648993ba127a9c15084549406157d4..b88ad21d7bcdad02555c37aedb8c4e98e131eaa3 100644
--- a/components/autofill/core/browser/autofill_external_delegate.h
+++ b/components/autofill/core/browser/autofill_external_delegate.h
@@ -61,6 +61,7 @@ class AutofillExternalDelegate
   virtual void OnQuery(int query_id,
                        const FormData& form,
                        const FormFieldData& field,
+                       const PasswordForm& passwordform,

[vabr (Chromium), 2014/01/13 14:46:29]

nit: "password form" are two words, so it's better to name the variable
password_form (with the underscore).
(Also on other places in this CL where you use "passwordform".)

[riadh.chtara, 2014/01/13 20:34:10]

Done.

[vabr (Chromium), 2014/01/14 14:11:02]

I'm still seeing many occurrences of "passwordform" in patch set 3.

                        const gfx::RectF& element_bounds,
                        bool display_warning_if_disabled);
 
@@ -77,6 +78,7 @@ class AutofillExternalDelegate
   void OnShowPasswordSuggestions(const std::vector<base::string16>& suggestions,
                                  const std::vector<base::string16>& realms,
                                  const FormFieldData& field,
+                                 const PasswordForm& passwordform,
                                  const gfx::RectF& bounds);
 
   // Set the data list value associated with the current field.
@@ -144,6 +146,7 @@ class AutofillExternalDelegate
   // The current form and field selected by Autofill.
   FormData autofill_query_form_;
   FormFieldData autofill_query_field_;
+  PasswordForm autofill_query_password_form_;

[vabr (Chromium), 2014/01/13 14:46:29]

Please put in a comment about what is this member variable for.

[riadh.chtara, 2014/01/13 20:34:10]

Done.

 
   // The bounds of the form field that user is interacting with.
   gfx::RectF element_bounds_;