Allow deleting autofill password suggestions on Shift+Delete

chrome/browser/password_manager/password_manager.cc

Index: chrome/browser/password_manager/password_manager.cc
diff --git a/chrome/browser/password_manager/password_manager.cc b/chrome/browser/password_manager/password_manager.cc
index 80392991c52f996d95743a3daab91cdd69e6fb07..1092488ee1e624446c927a1a7a0ee079b7991953 100644
--- a/chrome/browser/password_manager/password_manager.cc
+++ b/chrome/browser/password_manager/password_manager.cc
@@ -14,6 +14,8 @@
 #include "chrome/browser/password_manager/password_form_manager.h"
 #include "chrome/browser/password_manager/password_manager_delegate.h"
 #include "chrome/browser/password_manager/password_manager_metrics_util.h"
+#include "chrome/browser/password_manager/password_store.h"
+#include "chrome/browser/password_manager/password_store_factory.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller.h"
 #include "chrome/common/chrome_switches.h"
@@ -263,6 +265,8 @@ bool PasswordManager::OnMessageReceived(const IPC::Message& message) {
                         OnPasswordFormsRendered)
     IPC_MESSAGE_HANDLER(AutofillHostMsg_PasswordFormSubmitted,
                         OnPasswordFormSubmitted)
+    IPC_MESSAGE_HANDLER(AutofillHostMsg_RemovePasswordSuggestion,
+                        OnRemovePasswordSuggestion)
     IPC_MESSAGE_UNHANDLED(handled = false)
   IPC_END_MESSAGE_MAP()
   return handled;
@@ -352,6 +356,14 @@ void PasswordManager::OnPasswordFormsRendered(
   }
 }
 
+void PasswordManager::OnRemovePasswordSuggestion(
+    const PasswordForm& password_form) {
+  scoped_refptr<PasswordStore> password_store
+             = PasswordStoreFactory::GetForProfile(
+      delegate_->GetProfile(), Profile::EXPLICIT_ACCESS);
+  password_store.get()->RemoveLogin(password_form);

[vabr (Chromium), 2014/01/13 14:46:29]

You don't need .get() when using the operator -> .

[riadh.chtara, 2014/01/13 20:34:10]

Done.

[vabr (Chromium), 2014/01/14 14:11:02]

Does not seem done -- there is still the ".get()" part on this line.

+}
+
 void PasswordManager::PossiblyInitializeUsernamesExperiment(
     const PasswordFormMap& best_matches) const {
   if (base::FieldTrialList::Find(kOtherPossibleUsernamesExperiment))