Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: components/autofill/content/common/autofill_messages.h

Issue 133893004: Allow deleting autofill password suggestions on Shift+Delete (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: ToT Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/common/autofill_messages.h
diff --git a/components/autofill/content/common/autofill_messages.h b/components/autofill/content/common/autofill_messages.h
index d97dbf1e25641be03a7a002d7cee4dedca4a0784..9596db8f72bce527af492bfcacfef0230d913332 100644
--- a/components/autofill/content/common/autofill_messages.h
+++ b/components/autofill/content/common/autofill_messages.h
@@ -155,6 +155,12 @@ IPC_MESSAGE_ROUTED2(AutofillMsg_RequestAutocompleteResult,
IPC_MESSAGE_ROUTED1(AutofillMsg_AccountCreationFormsDetected,
std::vector<autofill::FormData> /* forms */)
+// Instruct the renderer that a password suggestion has to be removed.
+// The renderer is going to clean the suggestion from the ui and
+// then ask the password manager to remove the password from the store.
+IPC_MESSAGE_ROUTED1(AutofillMsg_RemovePasswordSuggestion,
+ autofill::PasswordForm /* password to be removed */)
+
// Autofill messages sent from the renderer to the browser.
// TODO(creis): check in the browser that the renderer actually has permission
@@ -243,12 +249,20 @@ IPC_MESSAGE_ROUTED2(AutofillHostMsg_AddPasswordFormMapping,
// Instruct the browser to show a popup with the following suggestions from the
// password manager.
-IPC_MESSAGE_ROUTED4(AutofillHostMsg_ShowPasswordSuggestions,
+IPC_MESSAGE_ROUTED5(AutofillHostMsg_ShowPasswordSuggestions,
autofill::FormFieldData /* the form field */,
+ autofill::PasswordForm /* the password form */,
gfx::RectF /* input field bounds, window-relative */,
std::vector<base::string16> /* suggestions */,
std::vector<base::string16> /* realms */)
+// Instruct the browser that a password suggestion has to be removed.
+// Send also a list of forms that needs to be updated after the deletion
vabr (Chromium) 2014/04/01 16:56:08 needs -> need (not the list, but the forms need to
rchtara 2014/04/03 08:44:50 Done.
+IPC_MESSAGE_ROUTED2(AutofillHostMsg_RemovePasswordSuggestion,
+ autofill::PasswordForm /* the password form */,
+ std::vector<autofill::PasswordForm> /* password
vabr (Chromium) 2014/04/01 16:56:08 password -> password forms
rchtara 2014/04/03 08:44:50 Done.
+ to be updated */)
+
// Inform browser of data list values for the curent field.
IPC_MESSAGE_ROUTED2(AutofillHostMsg_SetDataList,
std::vector<base::string16> /* values */,

Powered by Google App Engine
This is Rietveld 408576698