Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Side by Side Diff: components/autofill/core/browser/autofill_manager.h

Issue 133893004: Allow deleting autofill password suggestions on Shift+Delete (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: deletion is working Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_ 5 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_
6 #define COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_ 6 #define COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_
7 7
8 #include <list> 8 #include <list>
9 #include <map> 9 #include <map>
10 #include <string> 10 #include <string>
11 #include <vector> 11 #include <vector>
12 12
13 #include "base/basictypes.h" 13 #include "base/basictypes.h"
14 #include "base/callback_forward.h" 14 #include "base/callback_forward.h"
15 #include "base/compiler_specific.h" 15 #include "base/compiler_specific.h"
16 #include "base/gtest_prod_util.h" 16 #include "base/gtest_prod_util.h"
17 #include "base/memory/scoped_ptr.h" 17 #include "base/memory/scoped_ptr.h"
18 #include "base/memory/scoped_vector.h" 18 #include "base/memory/scoped_vector.h"
19 #include "base/memory/weak_ptr.h" 19 #include "base/memory/weak_ptr.h"
20 #include "base/strings/string16.h" 20 #include "base/strings/string16.h"
21 #include "base/time/time.h" 21 #include "base/time/time.h"
22 #include "components/autofill/core/browser/autocomplete_history_manager.h" 22 #include "components/autofill/core/browser/autocomplete_history_manager.h"
23 #include "components/autofill/core/browser/autofill_download.h" 23 #include "components/autofill/core/browser/autofill_download.h"
24 #include "components/autofill/core/browser/autofill_manager_delegate.h" 24 #include "components/autofill/core/browser/autofill_manager_delegate.h"
25 #include "components/autofill/core/browser/form_structure.h" 25 #include "components/autofill/core/browser/form_structure.h"
26 #include "components/autofill/core/browser/personal_data_manager.h" 26 #include "components/autofill/core/browser/personal_data_manager.h"
27 #include "components/autofill/core/common/form_data.h" 27 #include "components/autofill/core/common/form_data.h"
28 #include "components/autofill/core/common/forms_seen_state.h" 28 #include "components/autofill/core/common/forms_seen_state.h"
29 #include "components/autofill/core/common/password_form.h"
vabr (Chromium) 2014/02/05 20:34:20 I believe you acn also revert all changes in this
29 #include "third_party/WebKit/public/web/WebFormElement.h" 30 #include "third_party/WebKit/public/web/WebFormElement.h"
30 31
31 class GURL; 32 class GURL;
32 33
33 namespace content { 34 namespace content {
34 class RenderViewHost; 35 class RenderViewHost;
35 class WebContents; 36 class WebContents;
36 } 37 }
37 38
38 namespace gfx { 39 namespace gfx {
(...skipping 15 matching lines...) Expand all
54 class AutofillManagerDelegate; 55 class AutofillManagerDelegate;
55 class AutofillManagerTestDelegate; 56 class AutofillManagerTestDelegate;
56 class AutofillMetrics; 57 class AutofillMetrics;
57 class AutofillProfile; 58 class AutofillProfile;
58 class AutofillType; 59 class AutofillType;
59 class CreditCard; 60 class CreditCard;
60 class FormStructureBrowserTest; 61 class FormStructureBrowserTest;
61 62
62 struct FormData; 63 struct FormData;
63 struct FormFieldData; 64 struct FormFieldData;
65 struct PasswordForm;
64 struct PasswordFormFillData; 66 struct PasswordFormFillData;
65 67
66 // Manages saving and restoring the user's personal information entered into web 68 // Manages saving and restoring the user's personal information entered into web
67 // forms. 69 // forms.
68 class AutofillManager : public AutofillDownloadManager::Observer { 70 class AutofillManager : public AutofillDownloadManager::Observer {
69 public: 71 public:
70 enum AutofillDownloadManagerState { 72 enum AutofillDownloadManagerState {
71 ENABLE_AUTOFILL_DOWNLOAD_MANAGER, 73 ENABLE_AUTOFILL_DOWNLOAD_MANAGER,
72 DISABLE_AUTOFILL_DOWNLOAD_MANAGER, 74 DISABLE_AUTOFILL_DOWNLOAD_MANAGER,
73 }; 75 };
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
137 const FormFieldData& field, 139 const FormFieldData& field,
138 const gfx::RectF& bounding_box, 140 const gfx::RectF& bounding_box,
139 bool display_warning); 141 bool display_warning);
140 void OnDidEndTextFieldEditing(); 142 void OnDidEndTextFieldEditing();
141 void OnHideAutofillUI(); 143 void OnHideAutofillUI();
142 void OnAddPasswordFormMapping( 144 void OnAddPasswordFormMapping(
143 const FormFieldData& form, 145 const FormFieldData& form,
144 const PasswordFormFillData& fill_data); 146 const PasswordFormFillData& fill_data);
145 void OnShowPasswordSuggestions( 147 void OnShowPasswordSuggestions(
146 const FormFieldData& field, 148 const FormFieldData& field,
149 const PasswordForm& password_form,
147 const gfx::RectF& bounds, 150 const gfx::RectF& bounds,
148 const std::vector<base::string16>& suggestions, 151 const std::vector<base::string16>& suggestions,
149 const std::vector<base::string16>& realms); 152 const std::vector<base::string16>& realms);
150 void OnSetDataList(const std::vector<base::string16>& values, 153 void OnSetDataList(const std::vector<base::string16>& values,
151 const std::vector<base::string16>& labels); 154 const std::vector<base::string16>& labels);
152 155
153 // Try and upload |form|. This differs from OnFormSubmitted() in a few ways. 156 // Try and upload |form|. This differs from OnFormSubmitted() in a few ways.
154 // - This function will only label the first <input type="password"> field 157 // - This function will only label the first <input type="password"> field
155 // as ACCOUNT_CREATION_PASSWORD. Other fields will stay unlabeled, as they 158 // as ACCOUNT_CREATION_PASSWORD. Other fields will stay unlabeled, as they
156 // should have been labeled during the upload for OnFormSubmitted(). 159 // should have been labeled during the upload for OnFormSubmitted().
(...skipping 207 matching lines...) Expand 10 before | Expand all | Expand 10 after
364 UserHappinessFormLoadAndSubmission); 367 UserHappinessFormLoadAndSubmission);
365 FRIEND_TEST_ALL_PREFIXES(AutofillMetricsTest, UserHappinessFormInteraction); 368 FRIEND_TEST_ALL_PREFIXES(AutofillMetricsTest, UserHappinessFormInteraction);
366 FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest, 369 FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest,
367 FormSubmittedAutocompleteEnabled); 370 FormSubmittedAutocompleteEnabled);
368 DISALLOW_COPY_AND_ASSIGN(AutofillManager); 371 DISALLOW_COPY_AND_ASSIGN(AutofillManager);
369 }; 372 };
370 373
371 } // namespace autofill 374 } // namespace autofill
372 375
373 #endif // COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_ 376 #endif // COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698