Allow deleting autofill password suggestions on Shift+Delete

components/autofill/core/browser/password_autofill_manager.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/logging.h"
 #include "components/autofill/core/browser/autofill_driver.h"
 #include "components/autofill/core/browser/password_autofill_manager.h"
+#include "components/autofill/core/common/autofill_messages.h"
 #include "ui/events/keycodes/keyboard_codes.h"
 
 namespace autofill {
 
 ////////////////////////////////////////////////////////////////////////////////
 // PasswordAutofillManager, public:
 
 PasswordAutofillManager::PasswordAutofillManager(
     AutofillDriver* autofill_driver) : autofill_driver_(autofill_driver) {
   DCHECK(autofill_driver);
@@ skipping 16 matching lines @@
 
   return false;
 }
 
 void PasswordAutofillManager::AddPasswordFormMapping(
     const FormFieldData& username_element,
     const PasswordFormFillData& password) {
   login_to_password_info_[username_element] = password;
 }
 
-void PasswordAutofillManager::Reset() {
-  login_to_password_info_.clear();
+bool PasswordAutofillManager::RemovePasswordSuggestion(
+    const FormFieldData& field,
+    const PasswordForm& password_form) {
+  LoginToPasswordInfoMap::iterator iter = login_to_password_info_.find(field);
+  if (iter == login_to_password_info_.end())
+    return false;
+  login_to_password_info_.erase(iter);
+
+  Send(new AutofillHostMsg_RemovePasswordSuggestion(routing_id(),
+                                                    *password_form));
+  return true;
 }
 
+void PasswordAutofillManager::Reset() { login_to_password_info_.clear(); }

[vabr (Chromium), 2014/01/14 15:01:21]

nit: This might be because of the automatic formatting, but could you please
revert the definition of Reset() into it's original state (3 lines instead of
1)?

The idea is to minimise the changes to the source (for easy look-ups in history
of who introduced which change). Because both variants of writing Reset() are
acceptable, and you don't change the code of it, we should leave it.

[riadh.chtara, 2014/01/17 08:25:08]

Yes you're right, it's git cl format who have done this

+
 ////////////////////////////////////////////////////////////////////////////////
 // PasswordAutofillManager, private:
 
 bool PasswordAutofillManager::WillFillUserNameAndPassword(
     const base::string16& current_username,
     const PasswordFormFillData& fill_data) {
   // Look for any suitable matches to current field text.
   if (fill_data.basic_data.fields[0].value == current_username)
     return true;
 
@@ skipping 23 matching lines @@
     PasswordFormFillData* found_password) {
   LoginToPasswordInfoMap::iterator iter = login_to_password_info_.find(field);
   if (iter == login_to_password_info_.end())
     return false;
 
   *found_password = iter->second;
   return true;
 }
 
 }  // namespace autofill