Allow deleting autofill password suggestions on Shift+Delete

components/autofill/core/browser/password_autofill_manager.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/logging.h"
 #include "components/autofill/core/browser/autofill_driver.h"
 #include "components/autofill/core/browser/password_autofill_manager.h"
+#include "components/autofill/core/common/autofill_messages.h"
 #include "ui/events/keycodes/keyboard_codes.h"
 
 namespace autofill {
 
 ////////////////////////////////////////////////////////////////////////////////
 // PasswordAutofillManager, public:
 
 PasswordAutofillManager::PasswordAutofillManager(
     AutofillDriver* autofill_driver) : autofill_driver_(autofill_driver) {
   DCHECK(autofill_driver);
@@ skipping 16 matching lines @@
 
   return false;
 }
 
 void PasswordAutofillManager::AddPasswordFormMapping(
     const FormFieldData& username_element,
     const PasswordFormFillData& password) {
   login_to_password_info_[username_element] = password;
 }
 
+bool PasswordAutofillManager::RemovePasswordSuggestion(
+    const FormFieldData& field,
+    const PasswordForm& passwordform) {
+  LoginToPasswordInfoMap::iterator iter = login_to_password_info_.find(field);
+  if (iter == login_to_password_info_.end())
+    return false;
+  login_to_password_info_.erase(iter);
+
+  scoped_ptr<PasswordForm> password_form = CreatePasswordForm(form);
+
+  Send(new AutofillHostMsg_RemovePasswordSuggestion(
+    routing_id(),
+    password_form.get()));

[vabr (Chromium), 2014/01/13 14:46:29]

*password_form
(dereference instead of getting a pointer)

[riadh.chtara, 2014/01/13 20:34:10]

Done.

[vabr (Chromium), 2014/01/14 14:11:02]

Does not look done -- there is still .get() instead of the dereference.

+  return true;
+}
+
 void PasswordAutofillManager::Reset() {
   login_to_password_info_.clear();
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // PasswordAutofillManager, private:
 
 bool PasswordAutofillManager::WillFillUserNameAndPassword(
     const base::string16& current_username,
     const PasswordFormFillData& fill_data) {
@@ skipping 27 matching lines @@
     PasswordFormFillData* found_password) {
   LoginToPasswordInfoMap::iterator iter = login_to_password_info_.find(field);
   if (iter == login_to_password_info_.end())
     return false;
 
   *found_password = iter->second;
   return true;
 }
 
 }  // namespace autofill