Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Side by Side Diff: components/autofill/core/browser/autofill_manager.h

Issue 133893004: Allow deleting autofill password suggestions on Shift+Delete (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Allow deleting autofill password suggestions on Shift+Delete Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_ 5 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_
6 #define COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_ 6 #define COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_
7 7
8 #include <list> 8 #include <list>
9 #include <map> 9 #include <map>
10 #include <string> 10 #include <string>
11 #include <vector> 11 #include <vector>
12 12
13 #include "base/basictypes.h" 13 #include "base/basictypes.h"
14 #include "base/callback_forward.h" 14 #include "base/callback_forward.h"
15 #include "base/compiler_specific.h" 15 #include "base/compiler_specific.h"
16 #include "base/gtest_prod_util.h" 16 #include "base/gtest_prod_util.h"
17 #include "base/memory/scoped_ptr.h" 17 #include "base/memory/scoped_ptr.h"
18 #include "base/memory/scoped_vector.h" 18 #include "base/memory/scoped_vector.h"
19 #include "base/memory/weak_ptr.h" 19 #include "base/memory/weak_ptr.h"
20 #include "base/strings/string16.h" 20 #include "base/strings/string16.h"
21 #include "base/time/time.h" 21 #include "base/time/time.h"
22 #include "components/autofill/core/browser/autocomplete_history_manager.h" 22 #include "components/autofill/core/browser/autocomplete_history_manager.h"
23 #include "components/autofill/core/browser/autofill_download.h" 23 #include "components/autofill/core/browser/autofill_download.h"
24 #include "components/autofill/core/browser/autofill_manager_delegate.h" 24 #include "components/autofill/core/browser/autofill_manager_delegate.h"
25 #include "components/autofill/core/browser/form_structure.h" 25 #include "components/autofill/core/browser/form_structure.h"
26 #include "components/autofill/core/browser/personal_data_manager.h" 26 #include "components/autofill/core/browser/personal_data_manager.h"
27 #include "components/autofill/core/common/form_data.h" 27 #include "components/autofill/core/common/form_data.h"
28 #include "components/autofill/core/common/forms_seen_state.h" 28 #include "components/autofill/core/common/forms_seen_state.h"
29 #include "components/autofill/core/common/password_form.h"
29 #include "third_party/WebKit/public/web/WebFormElement.h" 30 #include "third_party/WebKit/public/web/WebFormElement.h"
30 31
31 class GURL; 32 class GURL;
32 33
34
vabr (Chromium) 2014/01/13 14:46:29 Please remove this extra line.
riadh.chtara 2014/01/13 20:34:10 Done.
33 namespace content { 35 namespace content {
34 class RenderViewHost; 36 class RenderViewHost;
35 class WebContents; 37 class WebContents;
36 } 38 }
37 39
38 namespace gfx { 40 namespace gfx {
39 class Rect; 41 class Rect;
40 class RectF; 42 class RectF;
41 } 43 }
42 44
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
128 const base::TimeTicks& timestamp); 130 const base::TimeTicks& timestamp);
129 131
130 void OnTextFieldDidChange(const FormData& form, 132 void OnTextFieldDidChange(const FormData& form,
131 const FormFieldData& field, 133 const FormFieldData& field,
132 const base::TimeTicks& timestamp); 134 const base::TimeTicks& timestamp);
133 135
134 // The |bounding_box| is a window relative value. 136 // The |bounding_box| is a window relative value.
135 void OnQueryFormFieldAutofill(int query_id, 137 void OnQueryFormFieldAutofill(int query_id,
136 const FormData& form, 138 const FormData& form,
137 const FormFieldData& field, 139 const FormFieldData& field,
140 const PasswordForm& passwordform,
138 const gfx::RectF& bounding_box, 141 const gfx::RectF& bounding_box,
139 bool display_warning); 142 bool display_warning);
140 void OnDidEndTextFieldEditing(); 143 void OnDidEndTextFieldEditing();
141 void OnHideAutofillUI(); 144 void OnHideAutofillUI();
142 void OnAddPasswordFormMapping( 145 void OnAddPasswordFormMapping(
143 const FormFieldData& form, 146 const FormFieldData& form,
144 const PasswordFormFillData& fill_data); 147 const PasswordFormFillData& fill_data);
145 void OnShowPasswordSuggestions( 148 void OnShowPasswordSuggestions(
146 const FormFieldData& field, 149 const FormFieldData& field,
150 const PasswordForm& passwordform,
147 const gfx::RectF& bounds, 151 const gfx::RectF& bounds,
148 const std::vector<base::string16>& suggestions, 152 const std::vector<base::string16>& suggestions,
149 const std::vector<base::string16>& realms); 153 const std::vector<base::string16>& realms);
150 void OnSetDataList(const std::vector<base::string16>& values, 154 void OnSetDataList(const std::vector<base::string16>& values,
151 const std::vector<base::string16>& labels); 155 const std::vector<base::string16>& labels);
152 156
153 // Try and upload |form|. This differs from OnFormSubmitted() in a few ways. 157 // Try and upload |form|. This differs from OnFormSubmitted() in a few ways.
154 // - This function will only label the first <input type="password"> field 158 // - This function will only label the first <input type="password"> field
155 // as ACCOUNT_CREATION_PASSWORD. Other fields will stay unlabeled, as they 159 // as ACCOUNT_CREATION_PASSWORD. Other fields will stay unlabeled, as they
156 // should have been labeled during the upload for OnFormSubmitted(). 160 // should have been labeled during the upload for OnFormSubmitted().
(...skipping 207 matching lines...) Expand 10 before | Expand all | Expand 10 after
364 UserHappinessFormLoadAndSubmission); 368 UserHappinessFormLoadAndSubmission);
365 FRIEND_TEST_ALL_PREFIXES(AutofillMetricsTest, UserHappinessFormInteraction); 369 FRIEND_TEST_ALL_PREFIXES(AutofillMetricsTest, UserHappinessFormInteraction);
366 FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest, 370 FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest,
367 FormSubmittedAutocompleteEnabled); 371 FormSubmittedAutocompleteEnabled);
368 DISALLOW_COPY_AND_ASSIGN(AutofillManager); 372 DISALLOW_COPY_AND_ASSIGN(AutofillManager);
369 }; 373 };
370 374
371 } // namespace autofill 375 } // namespace autofill
372 376
373 #endif // COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_ 377 #endif // COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698