Allow deleting autofill password suggestions on Shift+Delete

components/autofill/core/browser/autofill_external_delegate.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/autofill_external_delegate.h"
 
 #include "base/strings/utf_string_conversions.h"
 #include "components/autofill/core/browser/autocomplete_history_manager.h"
 #include "components/autofill/core/browser/autofill_driver.h"
 #include "components/autofill/core/browser/autofill_manager.h"
@@ skipping 17 matching lines @@
       has_shown_autofill_popup_for_current_edit_(false),
       weak_ptr_factory_(this) {
   DCHECK(autofill_manager);
 }
 
 AutofillExternalDelegate::~AutofillExternalDelegate() {}
 
 void AutofillExternalDelegate::OnQuery(int query_id,
                                        const FormData& form,
                                        const FormFieldData& field,
+                                       const PasswordForm& passwordform,

[vabr (Chromium), 2014/01/13 14:46:29]

Why do you actually need the PasswordForm in OnQuery? Would it be enough just to
receive it in OnShowPasswordSuggestions?
If yes, it would save you the hassle with templates and lot of lines in the
tests.

(I'm not sure myself, so if it's needed here as well, just don't be shy to let
me know why.)

[riadh.chtara, 2014/01/13 20:56:08]

I m not really but this the logic I followed:
When I created the  autofill_query_password_form_, I wanted something that
behave like  autofill_query_field_. So whenever autofill_query_field_ changes my
autofill_query_password_form_ needs to change too.
In OnQuery, autofill_query_field_ changes so this is why I changed the
autofill_query_password_form_.

[vabr (Chromium), 2014/01/14 14:11:02]

We should not just blindly copy the lifetime of another object. :)

I observed, when are OnQuery and OnShowPasswordSuggestions called:
OnQuery is triggered basically with any character typed into a form field.
OnShowPasswordSuggestions is triggered, when Chrome provides a credentials
suggestion, i.e., when you type something into the "username" field, and a
pop-up menu appears, containing some suggested credentials.

So to me it looks like you can leave OnQuery untouched, and only care about
OnShowPasswordSuggestions.

On 2014/01/13 20:56:08, riadh.chtara wrote:

                                        const gfx::RectF& element_bounds,
                                        bool display_warning_if_disabled) {
   autofill_query_form_ = form;
   autofill_query_field_ = field;
+  autofill_query_password_form_ = passwordform;
   display_warning_if_disabled_ = display_warning_if_disabled;
   autofill_query_id_ = query_id;
   element_bounds_ = element_bounds;
 }
 
 void AutofillExternalDelegate::OnSuggestionsReturned(
     int query_id,
     const std::vector<base::string16>& autofill_values,
     const std::vector<base::string16>& autofill_labels,
     const std::vector<base::string16>& autofill_icons,
@@ skipping 58 matching lines @@
         icons,
         ids,
         GetWeakPtr());
   }
 }
 
 void AutofillExternalDelegate::OnShowPasswordSuggestions(
     const std::vector<base::string16>& suggestions,
     const std::vector<base::string16>& realms,
     const FormFieldData& field,
+    const PasswordForm& passwordform,
     const gfx::RectF& element_bounds) {
   autofill_query_field_ = field;
+  autofill_query_password_form_ = passwordform;
   element_bounds_ = element_bounds;
 
   if (suggestions.empty()) {
     autofill_manager_->delegate()->HideAutofillPopup();
     return;
   }
 
   std::vector<base::string16> empty(suggestions.size());
   std::vector<int> password_ids(suggestions.size(),
                                 WebAutofillClient::MenuItemIDPasswordEntry);
@@ skipping 61 matching lines @@
     FillAutofillFormData(identifier, false);
   }
 
   autofill_manager_->delegate()->HideAutofillPopup();
 }
 
 void AutofillExternalDelegate::RemoveSuggestion(const base::string16& value,
                                                 int identifier) {
   if (identifier > 0) {
     autofill_manager_->RemoveAutofillProfileOrCreditCard(identifier);
+  } else if (identifier == WebAutofillClient::MenuItemIDPasswordEntry) {
+    bool success = password_autofill_manager_.RemovePasswordSuggestion(
+        autofill_query_field_,
+        autofill_query_password_form_);
+    DCHECK(success);
   } else {
     autofill_manager_->RemoveAutocompleteEntry(autofill_query_field_.name,
                                                value);
   }
 }
 
 void AutofillExternalDelegate::DidEndTextFieldEditing() {
   autofill_manager_->delegate()->HideAutofillPopup();
 
   has_shown_autofill_popup_for_current_edit_ = false;
@@ skipping 136 matching lines @@
   // Set the values that all datalist elements share.
   autofill_icons->insert(autofill_icons->begin(),
                          data_list_values_.size(),
                          base::string16());
   autofill_unique_ids->insert(autofill_unique_ids->begin(),
                               data_list_values_.size(),
                               WebAutofillClient::MenuItemIDDataListEntry);
 }
 
 }  // namespace autofill