Allow deleting autofill password suggestions on Shift+Delete

components/autofill/content/renderer/password_autofill_agent.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/content/renderer/password_autofill_agent.h"
 
 #include "base/bind.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop/message_loop.h"
 #include "base/metrics/histogram.h"
@@ skipping 594 matching lines @@
   std::vector<base::string16> suggestions;
   std::vector<base::string16> realms;
   GetSuggestions(fill_data, user_input.value(), &suggestions, &realms);
   DCHECK_EQ(suggestions.size(), realms.size());
 
   FormData form;
   FormFieldData field;
   FindFormAndFieldForInputElement(
       user_input, &form, &field, REQUIRE_NONE);
 
+  scoped_ptr<PasswordForm> password_form =
+                  CreatePasswordForm(user_input.form());
+  DCHECK(password_form.get());
+
   blink::WebInputElement selected_element = user_input;
   gfx::Rect bounding_box(selected_element.boundsInViewportSpace());
 
   float scale = web_view_->pageScaleFactor();
   gfx::RectF bounding_box_scaled(bounding_box.x() * scale,
                                  bounding_box.y() * scale,
                                  bounding_box.width() * scale,
                                  bounding_box.height() * scale);
   Send(new AutofillHostMsg_ShowPasswordSuggestions(routing_id(),
                                                    field,
+                                                   *password_form.get(),

[vabr (Chromium), 2014/01/13 14:46:29]

The ".get()" should not be needed.

[riadh.chtara, 2014/01/13 20:34:10]

Done.

[vabr (Chromium), 2014/01/14 14:11:02]

Again, not done -- ".get()" is still there.

                                                    bounding_box_scaled,
                                                    suggestions,
                                                    realms));
   return !suggestions.empty();
 }
 
 void PasswordAutofillAgent::FillFormOnPasswordRecieved(
     const PasswordFormFillData& fill_data,
     blink::WebInputElement username_element,
     blink::WebInputElement password_element) {
@@ skipping 189 matching lines @@
 }
 
 PasswordAutofillAgent::AutofillWebUserGestureHandler::
     AutofillWebUserGestureHandler(PasswordAutofillAgent* agent)
     : agent_(agent) {}
 
 PasswordAutofillAgent::AutofillWebUserGestureHandler::
     ~AutofillWebUserGestureHandler() {}
 
 }  // namespace autofill