Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Side by Side Diff: components/autofill/core/browser/autofill_manager.h

Issue 133893004: Allow deleting autofill password suggestions on Shift+Delete (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: ToT Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_ 5 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_
6 #define COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_ 6 #define COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_
7 7
8 #include <list> 8 #include <list>
9 #include <map> 9 #include <map>
10 #include <string> 10 #include <string>
(...skipping 28 matching lines...) Expand all
39 class Rect; 39 class Rect;
40 class RectF; 40 class RectF;
41 } 41 }
42 42
43 namespace user_prefs { 43 namespace user_prefs {
44 class PrefRegistrySyncable; 44 class PrefRegistrySyncable;
45 } 45 }
46 46
47 namespace autofill { 47 namespace autofill {
48 48
49 class AutofillDriver;
vabr (Chromium) 2014/04/01 16:56:08 This forward declaration looks unused, please remo
rchtara 2014/04/03 08:44:50 Done.
49 class AutofillDataModel; 50 class AutofillDataModel;
50 class AutofillDownloadManager; 51 class AutofillDownloadManager;
51 class AutofillExternalDelegate; 52 class AutofillExternalDelegate;
52 class AutofillField; 53 class AutofillField;
53 class AutofillManagerDelegate; 54 class AutofillManagerDelegate;
54 class AutofillManagerTestDelegate; 55 class AutofillManagerTestDelegate;
55 class AutofillMetrics; 56 class AutofillMetrics;
56 class AutofillProfile; 57 class AutofillProfile;
57 class AutofillType; 58 class AutofillType;
58 class CreditCard; 59 class CreditCard;
(...skipping 27 matching lines...) Expand all
86 void ShowAutofillSettings(); 87 void ShowAutofillSettings();
87 88
88 // Called from our external delegate so they cannot be private. 89 // Called from our external delegate so they cannot be private.
89 virtual void FillOrPreviewForm(AutofillDriver::RendererFormDataAction action, 90 virtual void FillOrPreviewForm(AutofillDriver::RendererFormDataAction action,
90 int query_id, 91 int query_id,
91 const FormData& form, 92 const FormData& form,
92 const FormFieldData& field, 93 const FormFieldData& field,
93 int unique_id); 94 int unique_id);
94 void DidShowSuggestions(bool is_new_popup); 95 void DidShowSuggestions(bool is_new_popup);
95 void OnDidFillAutofillFormData(const base::TimeTicks& timestamp); 96 void OnDidFillAutofillFormData(const base::TimeTicks& timestamp);
97 void OnShowAutofillDialog();
vabr (Chromium) 2014/04/01 16:56:08 Is this used?
rchtara 2014/04/03 08:44:50 Done.
96 void OnDidPreviewAutofillFormData(); 98 void OnDidPreviewAutofillFormData();
97 99
98 // Remove the credit card or Autofill profile that matches |unique_id| 100 // Remove the credit card or Autofill profile that matches |unique_id|
99 // from the database. 101 // from the database.
100 void RemoveAutofillProfileOrCreditCard(int unique_id); 102 void RemoveAutofillProfileOrCreditCard(int unique_id);
101 103
102 // Remove the specified Autocomplete entry. 104 // Remove the specified Autocomplete entry.
103 void RemoveAutocompleteEntry(const base::string16& name, 105 void RemoveAutocompleteEntry(const base::string16& name,
104 const base::string16& value); 106 const base::string16& value);
105 107
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
138 const FormFieldData& field, 140 const FormFieldData& field,
139 const gfx::RectF& bounding_box, 141 const gfx::RectF& bounding_box,
140 bool display_warning); 142 bool display_warning);
141 void OnDidEndTextFieldEditing(); 143 void OnDidEndTextFieldEditing();
142 void OnHidePopup(); 144 void OnHidePopup();
143 void OnAddPasswordFormMapping( 145 void OnAddPasswordFormMapping(
144 const FormFieldData& username_field, 146 const FormFieldData& username_field,
145 const PasswordFormFillData& fill_data); 147 const PasswordFormFillData& fill_data);
146 void OnShowPasswordSuggestions( 148 void OnShowPasswordSuggestions(
147 const FormFieldData& field, 149 const FormFieldData& field,
150 const PasswordForm& password_form,
148 const gfx::RectF& bounds, 151 const gfx::RectF& bounds,
149 const std::vector<base::string16>& suggestions, 152 const std::vector<base::string16>& suggestions,
150 const std::vector<base::string16>& realms); 153 const std::vector<base::string16>& realms);
151 void OnSetDataList(const std::vector<base::string16>& values, 154 void OnSetDataList(const std::vector<base::string16>& values,
152 const std::vector<base::string16>& labels); 155 const std::vector<base::string16>& labels);
153 156
154 // Try and upload |form|. This differs from OnFormSubmitted() in a few ways. 157 // Try and upload |form|. This differs from OnFormSubmitted() in a few ways.
155 // - This function will only label the first <input type="password"> field 158 // - This function will only label the first <input type="password"> field
156 // as ACCOUNT_CREATION_PASSWORD. Other fields will stay unlabeled, as they 159 // as ACCOUNT_CREATION_PASSWORD. Other fields will stay unlabeled, as they
157 // should have been labeled during the upload for OnFormSubmitted(). 160 // should have been labeled during the upload for OnFormSubmitted().
(...skipping 209 matching lines...) Expand 10 before | Expand all | Expand 10 after
367 UserHappinessFormLoadAndSubmission); 370 UserHappinessFormLoadAndSubmission);
368 FRIEND_TEST_ALL_PREFIXES(AutofillMetricsTest, UserHappinessFormInteraction); 371 FRIEND_TEST_ALL_PREFIXES(AutofillMetricsTest, UserHappinessFormInteraction);
369 FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest, 372 FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest,
370 FormSubmittedAutocompleteEnabled); 373 FormSubmittedAutocompleteEnabled);
371 DISALLOW_COPY_AND_ASSIGN(AutofillManager); 374 DISALLOW_COPY_AND_ASSIGN(AutofillManager);
372 }; 375 };
373 376
374 } // namespace autofill 377 } // namespace autofill
375 378
376 #endif // COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_ 379 #endif // COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698