Allow deleting autofill password suggestions on Shift+Delete

components/autofill/core/browser/autofill_external_delegate.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_EXTERNAL_DELEGATE_H_
 #define COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_EXTERNAL_DELEGATE_H_
 
 #include <vector>
 
 #include "base/compiler_specific.h"
@@ skipping 18 matching lines @@
 // TODO(csharp): A lot of the logic in this class is copied from autofillagent.
 // Once Autofill is moved out of WebKit this class should be the only home for
 // this logic. See http://crbug.com/51644
 
 // Delegate for in-browser Autocomplete and Autofill display and selection.
 class AutofillExternalDelegate
     : public AutofillPopupDelegate {
  public:
   // Creates an AutofillExternalDelegate for the specified AutofillManager and
   // AutofillDriver.
-  AutofillExternalDelegate(AutofillManager* manager,
-                           AutofillDriver* driver);
+  AutofillExternalDelegate(AutofillManager* autofill_manager,

[vabr (Chromium), 2014/04/01 16:56:08]

Please undo this change (adding the "autofill_" prefixes).

[rchtara, 2014/04/03 08:44:50]

Done.

+                           AutofillDriver* autofill_driver);
   virtual ~AutofillExternalDelegate();
 
   // AutofillPopupDelegate implementation.
   virtual void OnPopupShown() OVERRIDE;
   virtual void OnPopupHidden() OVERRIDE;
   virtual bool ShouldRepostEvent(const ui::MouseEvent& event) OVERRIDE;
   virtual void DidSelectSuggestion(int identifier) OVERRIDE;
   virtual void DidAcceptSuggestion(const base::string16& value,
                                    int identifier) OVERRIDE;
   virtual void RemoveSuggestion(const base::string16& value,
@@ skipping 15 matching lines @@
 
   // Records query results and correctly formats them before sending them off
   // to be displayed.  Called when an Autofill query result is available.
   virtual void OnSuggestionsReturned(
       int query_id,
       const std::vector<base::string16>& values,
       const std::vector<base::string16>& labels,
       const std::vector<base::string16>& icons,
       const std::vector<int>& unique_ids);
 
   // Show password suggestions in the popup.

[vabr (Chromium), 2014/04/01 16:56:08]

It should be mentioned, what is the purpose of |password_form|.

   void OnShowPasswordSuggestions(const std::vector<base::string16>& suggestions,
                                  const std::vector<base::string16>& realms,
                                  const FormFieldData& field,
+                                 const PasswordForm& password_form,
                                  const gfx::RectF& bounds);
 
   // Set the data list value associated with the current field.
   void SetCurrentDataListValues(
       const std::vector<base::string16>& data_list_values,
       const std::vector<base::string16>& data_list_labels);
 
   // Inform the delegate that the text field editing has ended. This is
   // used to help record the metrics of when a new popup is shown.
   void DidEndTextFieldEditing();
@@ skipping 46 matching lines @@
   // Password Autofill manager, handles all password-related Autofilling.
   PasswordAutofillManager password_manager_;
 
   // The ID of the last request sent for form field Autofill.  Used to ignore
   // out of date responses.
   int query_id_;
 
   // The current form and field selected by Autofill.
   FormData query_form_;
   FormFieldData query_field_;
+  // The current password selected by Autofill.
+  PasswordForm query_password_form_;
 
   // The bounds of the form field that user is interacting with.
   gfx::RectF element_bounds_;
 
   // Should we display a warning if Autofill is disabled?
   bool display_warning_if_disabled_;
 
   // Does the popup include any Autofill profile or credit card suggestions?
   bool has_suggestion_;
 
   // Have we already shown Autofill suggestions for the field the user is
   // currently editing?  Used to keep track of state for metrics logging.
   bool has_shown_popup_for_current_edit_;
 
   // The current data list values.
   std::vector<base::string16> data_list_values_;
   std::vector<base::string16> data_list_labels_;
 
   base::WeakPtrFactory<AutofillExternalDelegate> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(AutofillExternalDelegate);
 };
 
 }  // namespace autofill
 
 #endif  // COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_EXTERNAL_DELEGATE_H_