Allow deleting autofill password suggestions on Shift+Delete

components/autofill/core/browser/autofill_external_delegate.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/autofill_external_delegate.h"
 
 #include "base/strings/utf_string_conversions.h"
 #include "components/autofill/core/browser/autocomplete_history_manager.h"
 #include "components/autofill/core/browser/autofill_driver.h"
 #include "components/autofill/core/browser/autofill_manager.h"
@@ skipping 97 matching lines @@
         icons,
         ids,
         GetWeakPtr());
   }
 }
 
 void AutofillExternalDelegate::OnShowPasswordSuggestions(
     const std::vector<base::string16>& suggestions,
     const std::vector<base::string16>& realms,
     const FormFieldData& field,
+    const PasswordForm& password_form,
     const gfx::RectF& element_bounds) {
   query_field_ = field;
+  query_password_form_ = password_form;
   element_bounds_ = element_bounds;
 
   if (suggestions.empty()) {
     manager_->delegate()->HideAutofillPopup();
     return;
   }
 
   std::vector<base::string16> empty(suggestions.size());
   std::vector<int> password_ids(suggestions.size(),
                                 POPUP_ITEM_ID_PASSWORD_ENTRY);
@@ skipping 59 matching lines @@
     driver_->RendererShouldSetNodeText(value);
   } else {
     FillAutofillFormData(identifier, false);
   }
 
   manager_->delegate()->HideAutofillPopup();
 }
 
 void AutofillExternalDelegate::RemoveSuggestion(const base::string16& value,
                                                 int identifier) {
-  if (identifier > 0)
+  if (identifier > 0) {
     manager_->RemoveAutofillProfileOrCreditCard(identifier);
-  else
-    manager_->RemoveAutocompleteEntry(query_field_.name, value);
+  } else if (identifier == POPUP_ITEM_ID_PASSWORD_ENTRY) {
+    query_password_form_.username_value = value;
+    bool success = password_manager_.RemovePasswordSuggestion(
+       query_field_, query_password_form_);
+    DCHECK(success);
+  } else {
+    manager_->RemoveAutocompleteEntry(query_field_.name,
+                                               value);

[vabr (Chromium), 2014/04/01 16:56:08]

wrong indent

[rchtara, 2014/04/03 08:44:50]

Done.

+  }
 }
 
 void AutofillExternalDelegate::DidEndTextFieldEditing() {
   manager_->delegate()->HideAutofillPopup();
 
   has_shown_popup_for_current_edit_ = false;
 }
 
 void AutofillExternalDelegate::ClearPreviewedForm() {
   driver_->RendererShouldClearPreviewedForm();
@@ skipping 127 matching lines @@
   // Set the values that all datalist elements share.
   icons->insert(icons->begin(),
                 data_list_values_.size(),
                 base::string16());
   unique_ids->insert(unique_ids->begin(),
                      data_list_values_.size(),
                      POPUP_ITEM_ID_DATALIST_ENTRY);
 }
 
 }  // namespace autofill