Allow deleting autofill password suggestions on Shift+Delete

components/autofill/content/renderer/password_autofill_agent.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/content/renderer/password_autofill_agent.h"
 
 #include "base/bind.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop/message_loop.h"
 #include "base/metrics/histogram.h"
@@ skipping 431 matching lines @@
                                                    password_forms));
   } else {
     Send(new AutofillHostMsg_PasswordFormsParsed(routing_id(), password_forms));
   }
 }
 
 bool PasswordAutofillAgent::OnMessageReceived(const IPC::Message& message) {
   bool handled = true;
   IPC_BEGIN_MESSAGE_MAP(PasswordAutofillAgent, message)
     IPC_MESSAGE_HANDLER(AutofillMsg_FillPasswordForm, OnFillPasswordForm)
+    IPC_MESSAGE_HANDLER(AutofillMsg_RemovePasswordSuggestion,
+                        OnRemovePasswordSuggestion)
     IPC_MESSAGE_UNHANDLED(handled = false)
   IPC_END_MESSAGE_MAP()
   return handled;
 }
 
 void PasswordAutofillAgent::DidStartLoading() {
   if (usernames_usage_ != NOTHING_TO_AUTOFILL) {
     UMA_HISTOGRAM_ENUMERATION("PasswordManager.OtherPossibleUsernamesUsage",
                               usernames_usage_, OTHER_POSSIBLE_USERNAMES_MAX);
     usernames_usage_ = NOTHING_TO_AUTOFILL;
@@ skipping 176 matching lines @@
     FormData form;
     FormFieldData field;
     FindFormAndFieldForInputElement(
         username_element, &form, &field, REQUIRE_NONE);
     Send(new AutofillHostMsg_AddPasswordFormMapping(
         routing_id(),
         field,
         form_data));
   }
 }
+void PasswordAutofillAgent::OnRemovePasswordSuggestion(
+    const PasswordForm& password_form) {
+
+  std::vector<PasswordForm> updated_password_forms;
+
+  LoginToPasswordInfoMap::iterator iter;
+  for (iter = login_to_password_info_.begin();
+       iter != login_to_password_info_.end();) {
+    scoped_ptr<PasswordForm> new_password_form(
+        CreatePasswordForm(iter->second.password_field.form()));
+    if (new_password_form.get()) {

[vabr (Chromium), 2014/04/01 16:56:08]

Should we also test if new_password_form is similar to password_form?

[rchtara, 2014/04/03 08:44:50]

I'm sure but i think it better to leave that to the password manager.
Testing whether two forms are similar is not easy . And if we do that we are
going to duplicate the code that already exist in the browser.
But we going to send less message.
So I"m not sure what to do?

+      login_to_password_info_.erase(iter++);
+      updated_password_forms.push_back(*new_password_form);
+    } else {
+      ++iter;
+    }
+  }
+
+  Send(new AutofillHostMsg_RemovePasswordSuggestion(
+      routing_id(), password_form, updated_password_forms));
+}
 
 ////////////////////////////////////////////////////////////////////////////////
 // PasswordAutofillAgent, private:
 
 void PasswordAutofillAgent::GetSuggestions(
     const PasswordFormFillData& fill_data,
     const base::string16& input,
     std::vector<base::string16>* suggestions,
     std::vector<base::string16>* realms) {
   if (StartsWith(fill_data.basic_data.fields[0].value, input, false)) {
@@ skipping 37 matching lines @@
   std::vector<base::string16> suggestions;
   std::vector<base::string16> realms;
   GetSuggestions(fill_data, user_input.value(), &suggestions, &realms);
   DCHECK_EQ(suggestions.size(), realms.size());
 
   FormData form;
   FormFieldData field;
   FindFormAndFieldForInputElement(
       user_input, &form, &field, REQUIRE_NONE);
 
+  scoped_ptr<PasswordForm> password_form =
+      CreatePasswordForm(user_input.form());

[vabr (Chromium), 2014/04/01 17:14:35]

To record, what we just spoke about: instead of creating the PasswordForm and
sending it to the browser, only to receive it back later, maybe you could store
the WebFormElement form (which is just a small handle to a refcounted object) as
a member variable here, and create the PasswordForm from it in
OnRemovePasswordSuggestion on demand.

[rchtara, 2014/04/03 08:44:50]

Done.

+  DCHECK(password_form);
+
   blink::WebInputElement selected_element = user_input;
   gfx::Rect bounding_box(selected_element.boundsInViewportSpace());
 
   float scale = web_view_->pageScaleFactor();
   gfx::RectF bounding_box_scaled(bounding_box.x() * scale,
                                  bounding_box.y() * scale,
                                  bounding_box.width() * scale,
                                  bounding_box.height() * scale);
   Send(new AutofillHostMsg_ShowPasswordSuggestions(routing_id(),
                                                    field,
+                                                   *password_form,
                                                    bounding_box_scaled,
                                                    suggestions,
                                                    realms));
   return !suggestions.empty();
 }
 
 void PasswordAutofillAgent::FillFormOnPasswordRecieved(
     const PasswordFormFillData& fill_data,
     blink::WebInputElement username_element,
     blink::WebInputElement password_element) {
@@ skipping 180 matching lines @@
   LoginToPasswordInfoMap::iterator iter = login_to_password_info_.find(input);
   if (iter == login_to_password_info_.end())
     return false;
 
   *found_input = input;
   *found_password = iter->second;
   return true;
 }
 
 }  // namespace autofill