Allow deleting autofill password suggestions on Shift+Delete

chrome/browser/password_manager/password_store.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/password_manager/password_store.h"
 
 #include "base/bind.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop/message_loop.h"
 #include "base/message_loop/message_loop_proxy.h"
@@ skipping 21 matching lines @@
 
   // OnGetPasswordStoreResults owns PasswordForms in the vector.
   consumer->OnGetPasswordStoreResults(*matched_forms);
 }
 
 void PostConsumerCallback(
     base::TaskRunner* task_runner,
     const CancelableTaskTracker::IsCanceledCallback& is_canceled_cb,
     PasswordStoreConsumer* consumer,
     const base::Time& ignore_logins_cutoff,
+    const PasswordForm& form,

[vabr (Chromium), 2014/03/07 23:43:36]

Please indicate, what is the form needed for. Ideally using the variable name,
or at least a comment.

[riadh.chtara, 2014/03/14 17:16:08]

it's not needed.
I forgot to remove it.
Sorry for that

     const vector<PasswordForm*>& matched_forms) {
   vector<PasswordForm*>* matched_forms_copy = new vector<PasswordForm*>();
   if (ignore_logins_cutoff.is_null()) {
     *matched_forms_copy = matched_forms;
   } else {
     // Apply |ignore_logins_cutoff| and delete old ones.
     for (size_t i = 0; i < matched_forms.size(); i++) {
       if (matched_forms[i]->date_created < ignore_logins_cutoff)
         delete matched_forms[i];
       else
@@ skipping 89 matching lines @@
 
   CancelableTaskTracker::IsCanceledCallback is_canceled_cb;
   CancelableTaskTracker::TaskId id =
       consumer->cancelable_task_tracker()->NewTrackedTaskId(&is_canceled_cb);
 
   ConsumerCallbackRunner callback_runner =
       base::Bind(&PostConsumerCallback,
                  base::MessageLoopProxy::current(),
                  is_canceled_cb,
                  consumer,
-                 ignore_logins_cutoff);
+                 ignore_logins_cutoff,
+                 form);
   ScheduleTask(
       base::Bind(&PasswordStore::GetLoginsImpl, this, form, callback_runner));
   return id;
 }
 
 CancelableRequestProvider::Handle PasswordStore::GetAutofillableLogins(
     PasswordStoreConsumer* consumer) {
   return Schedule(&PasswordStore::GetAutofillableLoginsImpl, consumer);
 }
 
@@ skipping 78 matching lines @@
 #endif  // !defined(OS_MACOSX)
   BrowserThread::PostTask(
       BrowserThread::UI, FROM_HERE,
       base::Bind(&PasswordStore::NotifyLoginsChanged, this));
 }
 
 void PasswordStore::NotifyLoginsChanged() {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   FOR_EACH_OBSERVER(Observer, observers_, OnLoginsChanged());
 }