Allow deleting autofill password suggestions on Shift+Delete

components/autofill/core/browser/autofill_external_delegate_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <vector>
 
 #include "base/compiler_specific.h"
 #include "base/strings/string16.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/test/base/chrome_render_view_host_test_harness.h"
 #include "chrome/test/base/testing_profile.h"
 #include "components/autofill/core/browser/autofill_manager.h"
 #include "components/autofill/core/browser/test_autofill_driver.h"
 #include "components/autofill/core/browser/test_autofill_external_delegate.h"
 #include "components/autofill/core/browser/test_autofill_manager_delegate.h"
 #include "components/autofill/core/common/form_data.h"
 #include "components/autofill/core/common/form_field_data.h"
 #include "components/autofill/core/common/password_form_fill_data.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "third_party/WebKit/public/web/WebAutofillClient.h"
+#include "third_party/WebKit/public/web/WebFormElement.h"
 #include "ui/gfx/rect.h"
 
 using testing::_;
 using blink::WebAutofillClient;
 
 namespace autofill {
 
 namespace {
 
 // A constant value to use as the Autofill query ID.
@@ skipping 90 matching lines @@
     autofill_driver_.reset();
     ChromeRenderViewHostTestHarness::TearDown();
   }
 
   // Issue an OnQuery call with the given |query_id|.
   void IssueOnQuery(int query_id) {
     const FormData form;
     FormFieldData field;
     field.is_focusable = true;
     field.should_autocomplete = true;
+    blink::WebFormElement webformelement;
     const gfx::RectF element_bounds;
 
-    external_delegate_->OnQuery(query_id, form, field, element_bounds, true);
+    external_delegate_->OnQuery(query_id, form, field, webformelement,
+                                element_bounds, true);
   }
 
   MockAutofillManagerDelegate manager_delegate_;
   scoped_ptr<MockAutofillDriver> autofill_driver_;
   scoped_ptr<MockAutofillManager> autofill_manager_;
   scoped_ptr<AutofillExternalDelegate> external_delegate_;
 };
 
 // Test that our external delegate called the virtual methods at the right time.
 TEST_F(AutofillExternalDelegateUnitTest, TestExternalDelegateVirtualCalls) {
@@ skipping 173 matching lines @@
 }
 
 // Test that the Autofill popup doesn't display a warning explaining why
 // Autofill is disabled for a website when there are no Autofill suggestions.
 // Regression test for http://crbug.com/105636
 TEST_F(AutofillExternalDelegateUnitTest, NoAutofillWarningsWithoutSuggestions) {
   const FormData form;
   FormFieldData field;
   field.is_focusable = true;
   field.should_autocomplete = false;
+  blink::WebFormElement webformelement;
   const gfx::RectF element_bounds;
 
-  external_delegate_->OnQuery(kQueryId, form, field, element_bounds, true);
+  external_delegate_->OnQuery(kQueryId, form, webformelement, field,
+                              element_bounds, true);
 
   EXPECT_CALL(manager_delegate_,
               ShowAutofillPopup(_, _, _, _, _, _, _)).Times(0);
   EXPECT_CALL(manager_delegate_, HideAutofillPopup()).Times(1);
 
   // This should not call ShowAutofillPopup.
   std::vector<base::string16> autofill_item;
   autofill_item.push_back(base::string16());
   std::vector<int> autofill_ids;
   autofill_ids.push_back(WebAutofillClient::MenuItemIDAutocompleteEntry);
@@ skipping 73 matching lines @@
 
   // The enums must be cast to ints to prevent compile errors on linux_rel.
   EXPECT_CALL(manager_delegate_,
               ShowAutofillPopup(
                   _, _, _, _, _,
                   testing::ElementsAre(
                       static_cast<int>(
                            WebAutofillClient::MenuItemIDPasswordEntry)),
                   _));
 
+  blink::WebFormElement webformelement;
   external_delegate_->OnShowPasswordSuggestions(suggestions,
                                                 realms,
                                                 field,
+                                                webformelement,
                                                 element_bounds);
 
   EXPECT_CALL(manager_delegate_, HideAutofillPopup());
 
   // This should trigger a call to hide the popup since
   // we've selected an option.
   external_delegate_->DidAcceptSuggestion(
       suggestions[0],
       WebAutofillClient::MenuItemIDPasswordEntry);
 }
@@ skipping 20 matching lines @@
       base::string16(),
       WebAutofillClient::MenuItemIDClearForm);
 }
 
 TEST_F(AutofillExternalDelegateUnitTest, ExternalDelegateHideWarning) {
   // Set up a field that shouldn't get autocompleted or display warnings.
   const FormData form;
   FormFieldData field;
   field.is_focusable = true;
   field.should_autocomplete = false;
+  blink::WebFormElement webformelement;
   const gfx::RectF element_bounds;
 
-  external_delegate_->OnQuery(kQueryId, form, field, element_bounds, false);
+  external_delegate_->OnQuery(kQueryId, form, field, webformelement,
+                              element_bounds, false);
 
   std::vector<base::string16> autofill_items;
   autofill_items.push_back(base::string16());
   std::vector<int> autofill_ids;
   autofill_ids.push_back(WebAutofillClient::MenuItemIDAutocompleteEntry);
 
   // Ensure the popup tries to hide itself, since it is not allowed to show
   // anything.
   EXPECT_CALL(manager_delegate_, HideAutofillPopup());
 
   external_delegate_->OnSuggestionsReturned(kQueryId,
                                             autofill_items,
                                             autofill_items,
                                             autofill_items,
                                             autofill_ids);
 }
 
 TEST_F(AutofillExternalDelegateUnitTest, ExternalDelegateSetNodeText) {
   EXPECT_CALL(manager_delegate_, HideAutofillPopup());
   base::string16 dummy_string(ASCIIToUTF16("baz foo"));
   EXPECT_CALL(*autofill_driver_,
               RendererShouldSetNodeText(dummy_string));
   external_delegate_->DidAcceptSuggestion(
       dummy_string,
       WebAutofillClient::MenuItemIDAutocompleteEntry);
 }
 
 }  // namespace autofill