Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Unified Diff: runtime/vm/assembler_arm.cc

Issue 1338923002: ARM & MIPS: Don't embed an address in the general class id fetch. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/assembler_mips.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/assembler_arm.cc
diff --git a/runtime/vm/assembler_arm.cc b/runtime/vm/assembler_arm.cc
index 8b5ddccc975c1b7c287a60aefdb3440899cd9aa4..afb5744960a19789ed8a5b8d27763062f13fd6f7 100644
--- a/runtime/vm/assembler_arm.cc
+++ b/runtime/vm/assembler_arm.cc
@@ -2009,12 +2009,9 @@ void Assembler::CompareClassId(Register object,
void Assembler::LoadClassIdMayBeSmi(Register result, Register object) {
- static const intptr_t kSmiCidSource = kSmiCid << RawObject::kClassIdTagPos;
-
- LoadImmediate(TMP, reinterpret_cast<int32_t>(&kSmiCidSource) + 1);
tst(object, Operand(kSmiTagMask));
- mov(TMP, Operand(object), NE);
- LoadClassId(result, TMP);
+ LoadClassId(result, object, NE);
+ LoadImmediate(result, kSmiCid, EQ);
}
« no previous file with comments | « no previous file | runtime/vm/assembler_mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698