Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 1338813004: Use ApplicationContext instead of Activity (Closed)

Created:
5 years, 3 months ago by Jaekyun Seok (inactive)
Modified:
5 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use ApplicationContext instead of Activity In document mode, multiple activities could be used concurrently. So registering and unregistering a receiver could happen on different ones, which causes Chrome crash. BUG=530097 Committed: https://crrev.com/a774b242861f73871f663c8bf4030908684fd6bf Cr-Commit-Position: refs/heads/master@{#348741}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Jaekyun Seok (inactive)
aurimas@ and tedchoc@, please review this CL.
5 years, 3 months ago (2015-09-14 01:25:12 UTC) #2
Ted C
lgtm
5 years, 3 months ago (2015-09-14 15:59:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1338813004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1338813004/1
5 years, 3 months ago (2015-09-14 22:13:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-14 22:20:17 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a774b242861f73871f663c8bf4030908684fd6bf Cr-Commit-Position: refs/heads/master@{#348741}
5 years, 3 months ago (2015-09-14 22:20:53 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:38:07 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a774b242861f73871f663c8bf4030908684fd6bf
Cr-Commit-Position: refs/heads/master@{#348741}

Powered by Google App Engine
This is Rietveld 408576698