base/android/java/src/org/chromium/base/BaseChromiumApplication.java - Issue 1338813003: GN: Side-load dex files as well as native code in incremental installs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/android/java/src/org/chromium/base/BaseChromiumApplication.java

Issue 1338813003: GN: Side-load dex files as well as native code in incremental installs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Python review comments 1 Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « base/android/java/release_src/org/chromium/base/IncrementalInstall.java ('k') | base/base.gyp » ('j') | build/android/devil/android/device_utils.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: base/android/java/src/org/chromium/base/BaseChromiumApplication.java

diff --git a/base/android/java/src/org/chromium/base/BaseChromiumApplication.java b/base/android/java/src/org/chromium/base/BaseChromiumApplication.java

index 9d1a408638cdf01f2e127d42298761665862bf7f..36dd3e2531e1e0e5e977cc45149b3687ad046166 100644

--- a/base/android/java/src/org/chromium/base/BaseChromiumApplication.java

+++ b/base/android/java/src/org/chromium/base/BaseChromiumApplication.java

@@ -20,7 +20,6 @@ public class BaseChromiumApplication extends Application {

@Override

protected void attachBaseContext(Context base) {

super.attachBaseContext(base);

nyquist 2015/09/16 06:30:45 Nit: Override now only calls super, and does not i

agrieve 2015/09/16 14:59:58 Done.

- IncrementalInstall.initialize(this);

}

/**

« no previous file with comments | « base/android/java/release_src/org/chromium/base/IncrementalInstall.java ('k') | base/base.gyp » ('j') | build/android/devil/android/device_utils.py » ('J')