Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Unified Diff: build/android/devil/android/device_utils_test.py

Issue 1338813003: GN: Side-load dex files as well as native code in incremental installs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix pylint warnings Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/devil/android/device_utils_test.py
diff --git a/build/android/devil/android/device_utils_test.py b/build/android/devil/android/device_utils_test.py
index 179681a76e765e073e2293da848ad905d62fff71..f798129d51139cc6ae8efd81bebb1b0d4bd2c44e 100755
--- a/build/android/devil/android/device_utils_test.py
+++ b/build/android/devil/android/device_utils_test.py
@@ -605,7 +605,7 @@ class DeviceUtilsInstallTest(DeviceUtilsTest):
'test.package'),
(self.call.device._GetApplicationPathsInternal('test.package'),
['/fake/data/app/test.package.apk']),
- self.call.adb.Uninstall('test.package', False),
+ self.call.device.Uninstall('test.package'),
self.call.adb.Install('/fake/test/app.apk', reinstall=False)):
self.device.Install('/fake/test/app.apk', retries=0, permissions=[])
@@ -690,12 +690,18 @@ class DeviceUtilsInstallSplitApkTest(DeviceUtilsTest):
class DeviceUtilsUninstallTest(DeviceUtilsTest):
-
def testUninstall_callsThrough(self):
with self.assertCalls(
+ (self.call.device._GetApplicationPathsInternal('test.package'),
+ ['/path.apk']),
self.call.adb.Uninstall('test.package', True)):
self.device.Uninstall('test.package', True)
+ def testUninstall_noop(self):
+ with self.assertCalls(
+ (self.call.device._GetApplicationPathsInternal('test.package'), [])):
+ self.device.Uninstall('test.package', True)
+
class DeviceUtilsSuTest(DeviceUtilsTest):
def testSu_preM(self):

Powered by Google App Engine
This is Rietveld 408576698