build/android/PRESUBMIT.py - Issue 1338813003: GN: Side-load dex files as well as native code in incremental installs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/PRESUBMIT.py

Issue 1338813003: GN: Side-load dex files as well as native code in incremental installs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix pylint warnings Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/PRESUBMIT.py

diff --git a/build/android/PRESUBMIT.py b/build/android/PRESUBMIT.py

index 668638956f1ba7d607b2a153c015e41d3deef7ba..877d1fc9541053c5d13e3238144a620d3a854735 100644

--- a/build/android/PRESUBMIT.py

+++ b/build/android/PRESUBMIT.py

@@ -16,16 +16,22 @@ def CommonChecks(input_api, output_api):

"""Returns a path relative to presubmit directory."""

return input_api.os_path.join(input_api.PresubmitLocalPath(), *dirs)

+ build_pys = [

+ r'gyp/.*\.py$',

+ r'gn/.*\.py',

+ r'incremental_install/.*\.py',

+ ]

output.extend(input_api.canned_checks.RunPylint(

input_api,

output_api,

pylintrc='pylintrc',

- black_list=[r'pylib/symbols/.*\.py$', r'gyp/.*\.py$', r'gn/.*\.py'],

+ # symbols has its own PRESUBMIT.py

+ black_list=build_pys + [r'pylib/symbols/.*\.py$'],

extra_paths_list=[J(), J('buildbot')]))

output.extend(input_api.canned_checks.RunPylint(

input_api,

output_api,

- white_list=[r'gyp/.*\.py$', r'gn/.*\.py'],

+ white_list=build_pys,

extra_paths_list=[J('gyp'), J('gn')]))

# Disabled due to http://crbug.com/410936

« no previous file with comments | « base/base.gyp ('k') | build/android/devil/android/apk_helper.py » ('j') | build/config/android/internal_rules.gni » ('J')