Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 1338803004: Clean up some GN toolchain args, especially NaCl. (Closed)

Created:
5 years, 3 months ago by brettw
Modified:
5 years, 3 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up some GN toolchain args, especially NaCl. Uses forward_variables_from for the gcc_toolchain and nacl_toolchain templates when applicable. Add the ability to clear the sanitizer flags and use this for nacl. Committed: https://crrev.com/f5d97233985fac498ada3def2c2b3f4e8bbaafd9 Cr-Commit-Position: refs/heads/master@{#348522}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -41 lines) Patch
M build/toolchain/gcc_toolchain.gni View 4 chunks +28 lines, -15 lines 0 comments Download
M build/toolchain/nacl_toolchain.gni View 1 chunk +22 lines, -26 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
brettw
5 years, 3 months ago (2015-09-11 20:39:38 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1338803004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1338803004/1
5 years, 3 months ago (2015-09-11 20:40:36 UTC) #4
Dirk Pranke
lgtm
5 years, 3 months ago (2015-09-11 20:42:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1338803004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1338803004/1
5 years, 3 months ago (2015-09-11 20:44:09 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/80754)
5 years, 3 months ago (2015-09-12 00:05:40 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1338803004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1338803004/1
5 years, 3 months ago (2015-09-12 02:04:13 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-12 03:04:29 UTC) #13
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f5d97233985fac498ada3def2c2b3f4e8bbaafd9 Cr-Commit-Position: refs/heads/master@{#348522}
5 years, 3 months ago (2015-09-12 03:05:06 UTC) #14
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:27:46 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f5d97233985fac498ada3def2c2b3f4e8bbaafd9
Cr-Commit-Position: refs/heads/master@{#348522}

Powered by Google App Engine
This is Rietveld 408576698