Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(771)

Issue 1338803003: Revert of Don't allow whitespace between elements with display:table-cell (Closed)

Created:
5 years, 3 months ago by nednguyen
Modified:
5 years, 3 months ago
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Don't allow whitespace between elements with display:table-cell (patchset #8 id:140001 of https://codereview.chromium.org/1280123004/ ) Reason for revert: Compile failure on 8011 stable (mac , precise 32, precise 64) BUG=530685 Original issue's description: > Don't allow whitespace between elements with display:table-cell > > In https://codereview.chromium.org/1065563005 we started allowing whitespace > inside anonymous table cells. We're only interested in anonymous table cells > that were generated to contain non-table-part content. If the anonymous cell > was generated to contain a form element with display:table-cell, for example, then > that is not a situation where we want to treat any whitespace before and > after the form element as renderable. > > BUG=515771 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201329 TBR=esprehn@chromium.org,mstensho@opera.com,robhogan@gmail.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=515771

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -153 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/table/table-row-before-after-content-around-table-cell-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
D LayoutTests/fast/table/whitespace-between-elements-with-table-cell-display.html View 1 chunk +0 lines, -28 lines 0 comments Download
D LayoutTests/fast/table/whitespace-between-elements-with-table-cell-display-2.html View 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/fast/table/whitespace-between-elements-with-table-cell-display-2-expected.html View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/fast/table/whitespace-between-elements-with-table-cell-display-3.html View 1 chunk +0 lines, -19 lines 0 comments Download
D LayoutTests/fast/table/whitespace-between-elements-with-table-cell-display-3-expected.html View 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/fast/table/whitespace-between-elements-with-table-cell-display-4.html View 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/fast/table/whitespace-between-elements-with-table-cell-display-4-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/fast/table/whitespace-between-elements-with-table-cell-display-expected.html View 1 chunk +0 lines, -25 lines 0 comments Download
M LayoutTests/platform/linux/tables/mozilla/bugs/bug2479-1-expected.txt View 2 chunks +13 lines, -0 lines 0 comments Download
M Source/core/dom/Text.cpp View 3 chunks +14 lines, -19 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
nednguyen
Created Revert of Don't allow whitespace between elements with display:table-cell
5 years, 3 months ago (2015-09-11 18:24:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1338803003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1338803003/1
5 years, 3 months ago (2015-09-11 18:25:02 UTC) #2
commit-bot: I haz the power
5 years, 3 months ago (2015-09-11 18:25:27 UTC) #4
Failed to apply patch for LayoutTests/TestExpectations:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file LayoutTests/TestExpectations
  Hunk #1 FAILED at 792.
  1 out of 1 hunk FAILED -- saving rejects to file
LayoutTests/TestExpectations.rej

Patch:       LayoutTests/TestExpectations
Index: LayoutTests/TestExpectations
diff --git a/LayoutTests/TestExpectations b/LayoutTests/TestExpectations
index
b53d60e76f31bfa174a4756a440b9b6178760d9b..197e941cba2a5fcc82fce6e510fa26fbb1628e11
100644
--- a/LayoutTests/TestExpectations
+++ b/LayoutTests/TestExpectations
@@ -792,9 +792,6 @@
 crbug.com/449197 virtual/gpu/fast/canvas/canvas-composite-video.html [
NeedsManualRebaseline ]
 crbug.com/449197 virtual/gpu/fast/canvas/canvas-drawImage-video.html [
NeedsManualRebaseline ]
 crbug.com/449197 virtual/gpu/fast/canvas/yuv-video-on-accelerated-canvas.html [
NeedsManualRebaseline ]
-
-crbug.com/515771
fast/table/table-row-before-after-content-around-table-cell.html [
NeedsRebaseline ]
-crbug.com/515771 tables/mozilla/bugs/bug2479-1.html [ NeedsRebaseline ]
 
 # When drawing subpixel smoothed glyphs, CoreGraphics will fake bold the
glyphs.
 # In this configuration, the pixel smoothed glyphs will be created from
subpixel smoothed glyphs.

Powered by Google App Engine
This is Rietveld 408576698