Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3078)

Unified Diff: runtime/vm/service/vmservice.dart

Issue 1338753004: Force disconnect all service clients when VM is shutting down (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/vm/service/client.dart ('K') | « runtime/vm/service/client.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/service/vmservice.dart
diff --git a/runtime/vm/service/vmservice.dart b/runtime/vm/service/vmservice.dart
index 4c12cdb1105e398fcef1fec59f6054aae7679f61..f2210c5face8a8122f9c119d909d6e3baece1796 100644
--- a/runtime/vm/service/vmservice.dart
+++ b/runtime/vm/service/vmservice.dart
@@ -106,10 +106,11 @@ class VMService extends MessageRouter {
void _exit() {
isolateLifecyclePort.close();
scriptLoadPort.close();
- // Create a copy of the set as a list because client.close() alters the set.
+ // Create a copy of the set as a list because client.disconnect() will
+ // alter the connected clients set.
var clientsList = clients.toList();
for (var client in clientsList) {
- client.close();
+ client.disconnect();
}
// Call embedder shutdown hook after the internal shutdown.
if (onShutdown != null) {
« runtime/vm/service/client.dart ('K') | « runtime/vm/service/client.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698