Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1338753003: Specify the source rect on the SourceGraphic (Closed)

Created:
5 years, 3 months ago by fs
Modified:
5 years, 3 months ago
CC:
fs, blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, Rik, danakj, dshwang, drott+blinkwatch_chromium.org, krit, eae+blinkwatch, f(malita), gyuyoung2, jbroman, jchaffraix+rendering, Justin Novosad, kouhei+svg_chromium.org, leviw+renderwatch, pdr+graphicswatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, slimming-paint-reviews_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Specify the source rect on the SourceGraphic Instead of carrying the source rectangle of the filter input (the 'SourceGraphic') in the Filter, specify it in the input FilterEffect (SourceGraphic). This allows for getting rid of the sourceImageRect() method on Filter and implementations (it's only actually non-empty for SVGFilter and related code-paths.) BUG=109224 Committed: https://crrev.com/fb392df9292a5e151726609c8e1c0c4f8cf8ede6 git-svn-id: svn://svn.chromium.org/blink/trunk@202346 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Patch Set 2 : Doh #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -19 lines) Patch
M Source/core/layout/svg/SVGLayoutTreeAsText.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/paint/SVGFilterPainter.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M Source/core/svg/graphics/filters/SVGFilter.h View 1 chunk +2 lines, -5 lines 0 comments Download
M Source/core/svg/graphics/filters/SVGFilter.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M Source/platform/graphics/filters/Filter.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/platform/graphics/filters/SourceGraphic.h View 2 chunks +4 lines, -1 line 0 comments Download
M Source/platform/graphics/filters/SourceGraphic.cpp View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1338753003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1338753003/20001
5 years, 3 months ago (2015-09-16 10:25:56 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-16 11:41:05 UTC) #4
fs
5 years, 3 months ago (2015-09-16 11:50:17 UTC) #6
Stephen White
LGTM
5 years, 3 months ago (2015-09-16 14:47:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1338753003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1338753003/20001
5 years, 3 months ago (2015-09-16 15:04:58 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=202346
5 years, 3 months ago (2015-09-16 15:10:49 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:55:53 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/fb392df9292a5e151726609c8e1c0c4f8cf8ede6

Powered by Google App Engine
This is Rietveld 408576698