Source/core/svg/SVGForeignObjectElement.h - Issue 133873003: Convert SVG <foreignObject> to use RenderObject::isChildAllowed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/SVGForeignObjectElement.h

Issue 133873003: Convert SVG <foreignObject> to use RenderObject::isChildAllowed (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Reupload. Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/svg/SVGForeignObjectElement.h

diff --git a/Source/core/svg/SVGForeignObjectElement.h b/Source/core/svg/SVGForeignObjectElement.h

index 9db9220fa3aac635bdab19c90823c2ba6843671b..d02aa04ff7cea3817cddc31da757485167775981 100644

--- a/Source/core/svg/SVGForeignObjectElement.h

+++ b/Source/core/svg/SVGForeignObjectElement.h

@@ -45,7 +45,7 @@ private:

virtual void svgAttributeChanged(const QualifiedName&) OVERRIDE;

virtual bool rendererIsNeeded(const RenderStyle&) OVERRIDE;

- virtual bool childShouldCreateRenderer(const Node& child) const OVERRIDE;

+ virtual bool childShouldCreateRenderer(const Node& child) const OVERRIDE { return true; }

virtual RenderObject* createRenderer(RenderStyle*) OVERRIDE;

virtual bool selfHasRelativeLengths() const OVERRIDE;

« no previous file with comments | « Source/core/rendering/svg/RenderSVGForeignObject.cpp ('k') | Source/core/svg/SVGForeignObjectElement.cpp » ('j') | no next file with comments »