Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 133873003: Convert SVG <foreignObject> to use RenderObject::isChildAllowed (Closed)

Created:
6 years, 11 months ago by fs
Modified:
6 years, 11 months ago
CC:
blink-reviews, krit, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, pdr, Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Convert SVG <foreignObject> to use RenderObject::isChildAllowed BUG=337607 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165763

Patch Set 1 #

Patch Set 2 : Reupload. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
M Source/core/rendering/svg/RenderSVGForeignObject.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGForeignObject.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/svg/SVGForeignObjectElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGForeignObjectElement.cpp View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
fs
6 years, 11 months ago (2014-01-24 16:11:28 UTC) #1
Stephen Chennney
LGTM, based on the review email diff (bad base files in upload). I presume that ...
6 years, 11 months ago (2014-01-24 16:18:09 UTC) #2
fs
On 2014/01/24 16:18:09, Stephen Chenney wrote: > LGTM, based on the review email diff (bad ...
6 years, 11 months ago (2014-01-24 16:45:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/133873003/100001
6 years, 11 months ago (2014-01-24 16:47:16 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-24 18:03:11 UTC) #5
Message was sent while issue was closed.
Change committed as 165763

Powered by Google App Engine
This is Rietveld 408576698