Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(835)

Issue 1338703002: [css-grid] Percentage columns should remove scrollbar's width (Closed)

Created:
5 years, 3 months ago by Manuel Rego
Modified:
5 years, 3 months ago
CC:
blink-reviews, jfernandez, szager+layoutwatch_chromium.org, zoltan1, svillar, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, Manuel Rego, leviw+renderwatch, jchaffraix+rendering, eae+blinkwatch
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[css-grid] Percentage columns should remove scrollbar's width Currently the calculation of percentage columns was not subtracting the scrollbar's size. Fixed LayoutGrid::computeUsedBreadthOfSpecifiedLength() to avoid this problem. Added test to check the behavior for both columns and rows. BUG=530504 TEST=fast/css-grid-layout/grid-percent-track-scrollbar.html Committed: https://crrev.com/b4005a55e98d2d37e52da4cfc8d7d71a1f4950ad git-svn-id: svn://svn.chromium.org/blink/trunk@202194 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -1 line) Patch
A LayoutTests/fast/css-grid-layout/grid-percent-track-scrollbar.html View 1 chunk +44 lines, -0 lines 0 comments Download
A LayoutTests/fast/css-grid-layout/grid-percent-track-scrollbar-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/layout/LayoutGrid.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (6 generated)
Manuel Rego
5 years, 3 months ago (2015-09-11 11:51:04 UTC) #2
svillar
Makes total sense lgtm
5 years, 3 months ago (2015-09-11 13:25:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1338703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1338703002/1
5 years, 3 months ago (2015-09-11 20:26:33 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/53525)
5 years, 3 months ago (2015-09-11 21:42:02 UTC) #7
cbiesinger
lgtm
5 years, 3 months ago (2015-09-11 22:13:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1338703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1338703002/1
5 years, 3 months ago (2015-09-14 07:15:04 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/106532)
5 years, 3 months ago (2015-09-14 08:27:10 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1338703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1338703002/1
5 years, 3 months ago (2015-09-14 08:37:07 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=202194
5 years, 3 months ago (2015-09-14 09:46:39 UTC) #15
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:31:18 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b4005a55e98d2d37e52da4cfc8d7d71a1f4950ad

Powered by Google App Engine
This is Rietveld 408576698