Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Side by Side Diff: tests/compiler/dart2js/analyze_dart2js_test.dart

Issue 1338683002: Add related types check to analyze_dart2js_test (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Cleanup. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library analyze_dart2js; 5 library analyze_dart2js;
6 6
7 import 'package:async_helper/async_helper.dart';
7 import 'package:compiler/src/filenames.dart'; 8 import 'package:compiler/src/filenames.dart';
9 import 'package:compiler/src/compiler.dart';
8 import 'analyze_helper.dart'; 10 import 'analyze_helper.dart';
9 import "package:async_helper/async_helper.dart"; 11 import 'related_types.dart';
10 12
11 /** 13 /**
12 * Map of whitelisted warnings and errors. 14 * Map of whitelisted warnings and errors.
13 * 15 *
14 * Only add a whitelisting together with a bug report to dartbug.com and add 16 * Only add a whitelisting together with a bug report to dartbug.com and add
15 * the bug issue number as a comment on the whitelisting. 17 * the bug issue number as a comment on the whitelisting.
16 * 18 *
17 * Use an identifiable suffix of the file uri as key. Use a fixed substring of 19 * Use an identifiable suffix of the file uri as key. Use a fixed substring of
18 * the error/warning message in the list of whitelistings for each file. 20 * the error/warning message in the list of whitelistings for each file.
19 */ 21 */
20 // TODO(johnniwinther): Support canonical URIs as keys and message kinds as 22 // TODO(johnniwinther): Support canonical URIs as keys and message kinds as
21 // values. 23 // values.
22 const Map<String,List<String>> WHITE_LIST = const { 24 const Map<String,List<String>> WHITE_LIST = const {
23 }; 25 };
24 26
25 void main() { 27 void main() {
26 var uri = currentDirectory.resolve('pkg/compiler/lib/src/dart2js.dart'); 28 var uri = currentDirectory.resolve('pkg/compiler/lib/src/dart2js.dart');
27 asyncTest(() => analyze([uri], WHITE_LIST)); 29 asyncTest(() => analyze([uri], WHITE_LIST, checkResults: checkResults));
28 } 30 }
31
32 bool checkResults(Compiler compiler,
33 CollectingDiagnosticHandler handler) {
34 checkRelatedTypes(compiler);
35 return !handler.hasHint;
36 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698