Issue 133863003: Revert of Never send a referrer header if the referrer is not a web url

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 133863003: Revert of Never send a referrer header if the referrer is not a web url (Closed)

Created:
6 years, 11 months ago by tdanderson

Modified:
6 years, 11 months ago

Reviewers:
jochen (gone - plz use gerrit), abarth-chromium

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Revert of Never send a referrer header if the referrer is not a web url (https://codereview.chromium.org/136583002/) Reason for revert: This is the probable cause for the failing browser test CorrectReferrer. See: http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests%20%28dbg%29/builds/1302/steps/browser_tests/logs/CorrectReferrer http://build.chromium.org/p/chromium.webkit/builders/Mac10.8%20Tests/builds/5398/steps/browser_tests/logs/CorrectReferrer http://build.chromium.org/p/chromium.webkit/builders/Win7%20Tests/builds/543/steps/browser_tests/logs/CorrectReferrer Original issue's description: > Never send a referrer header if the referrer is not a web url > > BUG=none > R=abarth@chromium.org > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165085 TBR=abarth@chromium.org,jochen@chromium.org NOTREECHECKS=true NOTRY=true BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165090

Patch Set 1 #

Created: 6 years, 11 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -52 lines)			Patch
M	Source/platform/blink_platform.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/platform/weborigin/SecurityPolicy.cpp	View	1 chunk	+0 lines, -3 lines	0 comments	Download
D	Source/platform/weborigin/SecurityPolicyTest.cpp	View	1 chunk	+0 lines, -48 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

tdanderson

Created Revert of Never send a referrer header if the referrer is not a web ...

6 years, 11 months ago (2014-01-14 20:52:06 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tdanderson@chromium.org/133863003/1

6 years, 11 months ago (2014-01-14 20:56:25 UTC) #2

jochen (gone - plz use gerrit)

6 years, 11 months ago (2014-01-15 15:32:32 UTC) #4

Message was sent while issue was closed.

A revert of this CL has been created in
https://codereview.chromium.org/130173004/ by jochen@chromium.org.

The reason for reverting is: Fixed the browser test meanwhile..

Expand Messages | Collapse Messages