chrome/browser/engagement/site_engagement_service.cc - Issue 1338603002: Implement a site engagement score based on time-on-site.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/engagement/site_engagement_service.cc

Issue 1338603002: Implement a site engagement score based on time-on-site. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Compile unit tests Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/engagement/site_engagement_service.h ('K') | « chrome/browser/engagement/site_engagement_service.h ('k') | chrome/browser/engagement/site_engagement_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/engagement/site_engagement_service.cc

diff --git a/chrome/browser/engagement/site_engagement_service.cc b/chrome/browser/engagement/site_engagement_service.cc

index 5f36f19ba525753cb54e04c913119451d858a8fa..f76161feb51c49e52a9a61c2b66e6b2913c9c6ac 100644

--- a/chrome/browser/engagement/site_engagement_service.cc

+++ b/chrome/browser/engagement/site_engagement_service.cc

@@ -167,7 +167,7 @@ SiteEngagementService::SiteEngagementService(Profile* profile)

SiteEngagementService::~SiteEngagementService() {

}

-void SiteEngagementService::HandleNavigation(const GURL& url) {

+void SiteEngagementService::HandleUserInput(const GURL& url) {

HostContentSettingsMap* settings_map = profile_->GetHostContentSettingsMap();

scoped_ptr<base::DictionaryValue> score_dict =

GetScoreDictForOrigin(settings_map, url);