Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5894)

Unified Diff: chrome/browser/engagement/site_engagement_service.cc

Issue 1338603002: Implement a site engagement score based on time-on-site. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More web contents validity checking Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/engagement/site_engagement_service.cc
diff --git a/chrome/browser/engagement/site_engagement_service.cc b/chrome/browser/engagement/site_engagement_service.cc
index 5f36f19ba525753cb54e04c913119451d858a8fa..b5be007e07bd196b2d358c795fd4b2555d6d1d08 100644
--- a/chrome/browser/engagement/site_engagement_service.cc
+++ b/chrome/browser/engagement/site_engagement_service.cc
@@ -58,7 +58,7 @@ const char* SiteEngagementScore::kLastEngagementTimeKey = "lastEngagementTime";
const double SiteEngagementScore::kMaxPoints = 100;
const double SiteEngagementScore::kMaxPointsPerDay = 5;
-const double SiteEngagementScore::kNavigationPoints = 1;
+const double SiteEngagementScore::kUserInputPoints = 1;
const int SiteEngagementScore::kDecayPeriodInDays = 7;
const double SiteEngagementScore::kDecayPoints = 5;
@@ -167,13 +167,13 @@ SiteEngagementService::SiteEngagementService(Profile* profile)
SiteEngagementService::~SiteEngagementService() {
}
-void SiteEngagementService::HandleNavigation(const GURL& url) {
+void SiteEngagementService::HandleUserInput(const GURL& url) {
HostContentSettingsMap* settings_map = profile_->GetHostContentSettingsMap();
scoped_ptr<base::DictionaryValue> score_dict =
GetScoreDictForOrigin(settings_map, url);
SiteEngagementScore score(&clock_, *score_dict);
- score.AddPoints(SiteEngagementScore::kNavigationPoints);
+ score.AddPoints(SiteEngagementScore::kUserInputPoints);
if (score.UpdateScoreDict(score_dict.get())) {
ContentSettingsPattern pattern(
ContentSettingsPattern::FromURLNoWildcard(url));

Powered by Google App Engine
This is Rietveld 408576698