Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(993)

Unified Diff: sdk/lib/_internal/pub/test/transformer/fails_to_load_a_pubspec_with_reserved_transformer_test.dart

Issue 133843006: Support configuring dart2js from the pubspec. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: code reivew Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/pub/test/transformer/fails_to_load_a_pubspec_with_reserved_transformer_test.dart
diff --git a/sdk/lib/_internal/pub/test/transformer/fails_to_load_a_pubspec_with_reserved_transformer_config_test.dart b/sdk/lib/_internal/pub/test/transformer/fails_to_load_a_pubspec_with_reserved_transformer_test.dart
similarity index 80%
rename from sdk/lib/_internal/pub/test/transformer/fails_to_load_a_pubspec_with_reserved_transformer_config_test.dart
rename to sdk/lib/_internal/pub/test/transformer/fails_to_load_a_pubspec_with_reserved_transformer_test.dart
index 739478486aed700891689879dcef200608f0e6f4..8eed7c46c334cbe7d829174580453f916f5a096c 100644
--- a/sdk/lib/_internal/pub/test/transformer/fails_to_load_a_pubspec_with_reserved_transformer_config_test.dart
+++ b/sdk/lib/_internal/pub/test/transformer/fails_to_load_a_pubspec_with_reserved_transformer_test.dart
@@ -13,11 +13,11 @@ import '../serve/utils.dart';
main() {
initConfig();
- integration("fails to load a pubspec with reserved transformer config", () {
+ integration("fails to load a pubspec with reserved transformer", () {
d.dir(appPath, [
d.pubspec({
"name": "myapp",
- "transformers": [{"myapp/src/transformer": {'include': 'something'}}]
+ "transformers": ["\$nonexistent"]
}),
d.dir("lib", [d.dir("src", [
d.file("transformer.dart", REWRITE_TRANSFORMER)
@@ -30,8 +30,8 @@ main() {
expect(pub.nextErrLine(), completion(equals('Error in pubspec for package '
'"myapp" loaded from pubspec.yaml:')));
expect(pub.nextErrLine(), completion(equals('Invalid transformer '
- 'identifier for "transformers.myapp/src/transformer": Transformer '
- 'configuration may not include reserved key "include".')));
+ 'identifier for "transformers.\$nonexistent": Unsupported built-in '
+ 'transformer \$nonexistent.')));
pub.shouldExit(1);
});
}

Powered by Google App Engine
This is Rietveld 408576698