sdk/lib/_internal/pub/lib/src/pubspec.dart - Issue 133843006: Support configuring dart2js from the pubspec.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/pub/lib/src/pubspec.dart

Issue 133843006: Support configuring dart2js from the pubspec. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: code reivew Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/_internal/pub/lib/src/pubspec.dart

diff --git a/sdk/lib/_internal/pub/lib/src/pubspec.dart b/sdk/lib/_internal/pub/lib/src/pubspec.dart

index c5c5c1aff278d5aa49304c78a559975442034eea..df9359a078c0bc5a8fb443a84b2bb2c599bc3d04 100644

--- a/sdk/lib/_internal/pub/lib/src/pubspec.dart

+++ b/sdk/lib/_internal/pub/lib/src/pubspec.dart

@@ -177,7 +177,7 @@ class Pubspec {

"$field.$library",

() => new TransformerId.parse(library, configuration));

- if (id.package != name &&

+ if (id.package != name && !id.isBuiltInTransformer &&

!dependencies.any((ref) => ref.name == id.package)) {

_error('"$field.$library" refers to a package that\'s not listed in '

'"dependencies".');