Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 133843004: Revert 244233 "Add support for using expressions as enum values." (Closed)

Created:
6 years, 11 months ago by DaleCurtis
Modified:
6 years, 11 months ago
Reviewers:
mpcomplete
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 244233 "Add support for using expressions as enum values." > Add support for using expressions as enum values. > > BUG=320090 > R=darin@chromium.org > > Review URL: https://codereview.chromium.org/130443003 Broke the android build: http://build.chromium.org/p/chromium.linux/buildstatus?builder=Android%20Builder%20%28dbg%29&number=50248 TBR=mpcomplete@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244237

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -393 lines) Patch
D trunk/src/mojo/public/bindings/parse/mojo_lexer.py View 1 chunk +0 lines, -304 lines 0 comments Download
M trunk/src/mojo/public/bindings/parse/mojo_parser.py View 9 chunks +114 lines, -86 lines 0 comments Download
M trunk/src/mojo/public/bindings/sample/sample_service.mojom View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
DaleCurtis
6 years, 11 months ago (2014-01-10 20:56:39 UTC) #1
DaleCurtis
6 years, 11 months ago (2014-01-10 20:58:01 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r244237 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698