Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Unified Diff: tools/telemetry/telemetry/internal/platform/tracing_agent/chrome_tracing_devtools_manager.py

Issue 1338423007: [Telemetry] Platform-level tracing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review fix Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/internal/platform/tracing_agent/chrome_tracing_devtools_manager.py
diff --git a/tools/telemetry/telemetry/internal/platform/tracing_agent/chrome_tracing_devtools_manager.py b/tools/telemetry/telemetry/internal/platform/tracing_agent/chrome_tracing_devtools_manager.py
index de51ea6a1ae4a61fa01dc5a6ae2766be706c8835..ea2bde201d61ea740283dc15db17925f5ebc5ffb 100644
--- a/tools/telemetry/telemetry/internal/platform/tracing_agent/chrome_tracing_devtools_manager.py
+++ b/tools/telemetry/telemetry/internal/platform/tracing_agent/chrome_tracing_devtools_manager.py
@@ -2,10 +2,6 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-class RegisterDevToolsClientError(Exception):
- pass
-
-
# A singleton map from platform backends to maps of uniquely-identifying
# remote port (which may be the same as local port) to DevToolsClientBackend.
# There is no guarantee that the devtools agent is still alive.
@@ -30,11 +26,6 @@ def RegisterDevToolsClient(devtools_client_backend, platform_backend):
This should only be called from DevToolsClientBackend when it is initialized.
"""
- if platform_backend.tracing_controller_backend.is_tracing_running:
- raise RegisterDevToolsClientError(
- 'Cannot add new DevTools client when tracing is running on '
- 'platform backend %s.' % platform_backend)
-
remote_port = str(devtools_client_backend.remote_port)
if platform_backend not in _platform_backends_to_devtools_clients_maps:
_platform_backends_to_devtools_clients_maps[platform_backend] = {}

Powered by Google App Engine
This is Rietveld 408576698