tools/telemetry/telemetry/internal/backends/chrome_inspector/tracing_backend.py - Issue 1338423007: [Telemetry] Platform-level tracing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/internal/backends/chrome_inspector/tracing_backend.py

Issue 1338423007: [Telemetry] Platform-level tracing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review fix Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/internal/backends/chrome_inspector/devtools_client_backend.py ('k') | tools/telemetry/telemetry/internal/platform/tracing_agent/chrome_tracing_agent.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/internal/backends/chrome_inspector/tracing_backend.py

diff --git a/tools/telemetry/telemetry/internal/backends/chrome_inspector/tracing_backend.py b/tools/telemetry/telemetry/internal/backends/chrome_inspector/tracing_backend.py

index dadf4a32f3bd92037ab58efd1660838bd77c0eaf..e68e80e7d0e7df7eea8422d8256bbc30dccbf99b 100644

--- a/tools/telemetry/telemetry/internal/backends/chrome_inspector/tracing_backend.py

+++ b/tools/telemetry/telemetry/internal/backends/chrome_inspector/tracing_backend.py

@@ -97,7 +97,7 @@ class _DevToolsStreamReader(object):

class TracingBackend(object):

- def __init__(self, devtools_port):

+ def __init__(self, devtools_port, is_tracing_running=False):

self._inspector_websocket = inspector_websocket.InspectorWebsocket()

self._inspector_websocket.RegisterDomain(

'Tracing', self._NotificationHandler)

@@ -105,7 +105,7 @@ class TracingBackend(object):

self._inspector_websocket.Connect(

'ws://127.0.0.1:%i/devtools/browser' % devtools_port)

self._trace_events = []

- self._is_tracing_running = False

+ self._is_tracing_running = is_tracing_running

self._has_received_all_tracing_data = False

@property