tools/telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py - Issue 1338423007: [Telemetry] Platform-level tracing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py

Issue 1338423007: [Telemetry] Platform-level tracing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review fix Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/tracing_controller_unittest.py ('k') | tools/telemetry/telemetry/internal/backends/chrome_inspector/devtools_client_backend.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py

diff --git a/tools/telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py b/tools/telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py

index 9c5802d9254b908226191c3432623da7aa53c10a..fe58c01556b8787f517075ded123bd7a3c55a51d 100644

--- a/tools/telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py

+++ b/tools/telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py

@@ -218,6 +218,10 @@ class DesktopBrowserBackend(chrome_browser_backend.ChromeBrowserBackend):

args.append('--ppapi-flash-path=%s' % self._flash_path)

if not self.browser_options.dont_override_profile:

args.append('--user-data-dir=%s' % self._tmp_profile_dir)

+ trace_config_file = (self.platform_backend.tracing_controller_backend

+ .GetChromeTraceConfigFile())

+ if trace_config_file:

+ args.append('--trace-config-file=%s' % trace_config_file)

return args

def Start(self):