Issue 1338403003: Revert of Test that GrFragmentProcessors work without input colors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1338403003: Revert of Test that GrFragmentProcessors work without input colors. (Closed)

Created:
5 years, 3 months ago by bsalomon

Modified:
5 years, 1 month ago

Reviewers:
joshualitt

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Revert of Test that GrFragmentProcessors work without input colors. (patchset #2 id:20001 of https://codereview.chromium.org/1341853002/ ) Reason for revert: Need to fix up more processor subclasses. Original issue's description: > Test that GrFragmentProcessors work without input colors. > > Committed: https://skia.googlesource.com/skia/+/72c58e7052af2a0855412ce4b249f977069db751 TBR=joshualitt@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/59ce45fe7984b3ee1bdbd107805a3146a0064fab

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -113 lines)			Patch
M	include/gpu/GrProcessorUnitTest.h	View	1 chunk	+1 line, -10 lines	0 comments	Download
M	src/gpu/effects/GrExtractAlphaFragmentProcessor.cpp	View	1 chunk	+3 lines, -7 lines	0 comments	Download
M	src/gpu/effects/GrXfermodeFragmentProcessor.cpp	View	3 chunks	+9 lines, -16 lines	0 comments	Download
M	tests/GLProgramsTest.cpp	View	5 chunks	+4 lines, -80 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

bsalomon

Created Revert of Test that GrFragmentProcessors work without input colors.

5 years, 3 months ago (2015-09-14 19:01:22 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1338403003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1338403003/1

5 years, 3 months ago (2015-09-14 19:01:37 UTC) #2

commit-bot: I haz the power

5 years, 3 months ago (2015-09-14 19:01:46 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/59ce45fe7984b3ee1bdbd107805a3146a0064fab

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages