Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2613)

Unified Diff: chrome/android/BUILD.gn

Issue 1338393003: GN: Fix ChromePublic crash on launch from misconfigured resource overrides (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: line length Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/android/rules.gni ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/BUILD.gn
diff --git a/chrome/android/BUILD.gn b/chrome/android/BUILD.gn
index ceef92f12c78cc117f5d266e91e9535e515c0a9e..73db3acce462bbee35ffd45784b6f02cbf11fbcc 100644
--- a/chrome/android/BUILD.gn
+++ b/chrome/android/BUILD.gn
@@ -43,10 +43,10 @@ locale_pak_resources("chrome_locale_paks") {
# GYP: //chrome/chrome.gyp:chrome_java (resources part)
android_resources("chrome_java_resources") {
- if (!defined(android_branding_res_dirs)) {
- android_branding_res_dirs = [ "//chrome/android/java/res_chromium" ]
- }
- resource_dirs = [ "java/res" ] + android_branding_res_dirs
+ resource_dirs = [
+ "java/res",
+ "//chrome/android/java/res_chromium",
+ ]
deps = [
":chrome_locale_paks",
":chrome_strings_grd",
@@ -334,9 +334,14 @@ android_library("chrome_shared_test_java") {
]
}
+# Overrides icon / name defined in chrome_java_resources.
android_resources("chrome_public_apk_resources") {
resource_dirs = [ "java/res_chromium" ]
- custom_package = "org.chromium.chrome"
+
+ # Dep needed to ensure override works properly.
+ deps = [
+ ":chrome_java_resources",
+ ]
}
chrome_public_apk_assets_dir = "$root_build_dir/chrome_public_apk_assets"
@@ -425,7 +430,6 @@ android_apk("chrome_public_apk") {
deps = [
":chrome_java",
- ":chrome_java_resources",
":chrome_public",
":chrome_public_apk_assets",
":chrome_public_apk_manifest",
« no previous file with comments | « build/config/android/rules.gni ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698