Certificate Transparency: Add Venafi log

net/cert/ct_known_logs_static.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file is generated by print_log_list.py
 #ifndef NET_CERT_CT_KNOWN_LOGS_STATIC_H_
 #define NET_CERT_CT_KNOWN_LOGS_STATIC_H_
 
 struct CTLogInfo {
-  const char log_key[92];
+  const char log_key[295];

[Ryan Sleevi, 2015/09/14 21:15:25]

I'm wondering whether or not this string should be externalized. The result is
that you're allocating 295 bytes now for every log, but that's kinda gross.

That is, something like

const char kAviatorKey[] = {...};
const char kVenafiKey[] = {...};

struct CTLogInfo {
  const char* const log_key;
  size_t log_key_length;
  const char* const log_name;
  const char* const log_url;
};

const CTLogInfo kCTLogList[] = {
  { kAviatorKey, sizeof(kAviatorKey), ... },
   ...,
  { kVenafiKey, sizeof(kVenafiKey), ... },
};



(We should also consider renaming this from .h to something like -inc.cc /
-inc.h, to make it clear it's not meant to be a generic header, so that we don't
get into multi-translation unit size bloat from having the same constant in
multiple TUs)

   const char* const log_name;
   const char* const log_url;
 };
 
 const CTLogInfo kCTLogList[] = {
     {"\x30\x59\x30\x13\x06\x07\x2a\x86\x48\xce\x3d\x02\x01\x06\x08\x2a\x86"
      "\x48\xce\x3d\x03\x01\x07\x03\x42\x00\x04\x7d\xa8\x4b\x12\x29\x80\xa3"
      "\x3d\xad\xd3\x5a\x77\xb8\xcc\xe2\x88\xb3\xa5\xfd\xf1\xd3\x0c\xcd\x18"
      "\x0c\xe8\x41\x46\xe8\x81\x01\x1b\x15\xe1\x4b\xf1\x1b\x62\xdd\x36\x0a"
      "\x08\x18\xba\xed\x0b\x35\x84\xd0\x9e\x40\x3c\x2d\x9e\x9b\x82\x65\xbd"
@@ skipping 40 matching lines @@
      "\xf6\x07\x76\xe0\xee\xbe",
      "Izenpe log",
      "https://ct.izenpe.com/"},
     {"\x30\x59\x30\x13\x06\x07\x2a\x86\x48\xce\x3d\x02\x01\x06\x08\x2a\x86"
      "\x48\xce\x3d\x03\x01\x07\x03\x42\x00\x04\x96\xea\xac\x1c\x46\x0c\x1b"
      "\x55\xdc\x0d\xfc\xb5\x94\x27\x46\x57\x42\x70\x3a\x69\x18\xe2\xbf\x3b"
      "\xc4\xdb\xab\xa0\xf4\xb6\x6c\xc0\x53\x3f\x4d\x42\x10\x33\xf0\x58\x97"
      "\x8f\x6b\xbe\x72\xf4\x2a\xec\x1c\x42\xaa\x03\x2f\x1a\x7e\x28\x35\x76"
      "\x99\x08\x3d\x21\x14\x86",
      "Symantec log",
-     "https://ct.ws.symantec.com/"}};
+     "https://ct.ws.symantec.com/"},
+    {"\x30\x82\x01\x22\x30\x0d\x06\x09\x2a\x86\x48\x86\xf7\x0d\x01\x01\x01"
+     "\x05\x00\x03\x82\x01\x0f\x00\x30\x82\x01\x0a\x02\x82\x01\x01\x00\xa2"
+     "\x5a\x48\x1f\x17\x52\x95\x35\xcb\xa3\x5b\x3a\x1f\x53\x82\x76\x94\xa3"
+     "\xff\x80\xf2\x1c\x37\x3c\xc0\xb1\xbd\xc1\x59\x8b\xab\x2d\x65\x93\xd7"
+     "\xf3\xe0\x04\xd5\x9a\x6f\xbf\xd6\x23\x76\x36\x4f\x23\x99\xcb\x54\x28"
+     "\xad\x8c\x15\x4b\x65\x59\x76\x41\x4a\x9c\xa6\xf7\xb3\x3b\x7e\xb1\xa5"
+     "\x49\xa4\x17\x51\x6c\x80\xdc\x2a\x90\x50\x4b\x88\x24\xe9\xa5\x12\x32"
+     "\x93\x04\x48\x90\x02\xfa\x5f\x0e\x30\x87\x8e\x55\x76\x05\xee\x2a\x4c"
+     "\xce\xa3\x6a\x69\x09\x6e\x25\xad\x82\x76\x0f\x84\x92\xfa\x38\xd6\x86"
+     "\x4e\x24\x8f\x9b\xb0\x72\xcb\x9e\xe2\x6b\x3f\xe1\x6d\xc9\x25\x75\x23"
+     "\x88\xa1\x18\x58\x06\x23\x33\x78\xda\x00\xd0\x38\x91\x67\xd2\xa6\x7d"
+     "\x27\x97\x67\x5a\xc1\xf3\x2f\x17\xe6\xea\xd2\x5b\xe8\x81\xcd\xfd\x92"
+     "\x68\xe7\xf3\x06\xf0\xe9\x72\x84\xee\x01\xa5\xb1\xd8\x33\xda\xce\x83"
+     "\xa5\xdb\xc7\xcf\xd6\x16\x7e\x90\x75\x18\xbf\x16\xdc\x32\x3b\x6d\x8d"
+     "\xab\x82\x17\x1f\x89\x20\x8d\x1d\x9a\xe6\x4d\x23\x08\xdf\x78\x6f\xc6"
+     "\x05\xbf\x5f\xae\x94\x97\xdb\x5f\x64\xd4\xee\x16\x8b\xa3\x84\x6c\x71"
+     "\x2b\xf1\xab\x7f\x5d\x0d\x32\xee\x04\xe2\x90\xec\x41\x9f\xfb\x39\xc1"
+     "\x02\x03\x01\x00\x01",
+     "Venafi log",
+     "https://ctlog.api.venafi.com/"}};
 
-const size_t kNumKnownCTLogs = 7;
+const size_t kNumKnownCTLogs = sizeof(kCTLogList) / sizeof(CTLogInfo);

[Ryan Sleevi, 2015/09/14 21:15:25]

I've mentioned to Eran this wasn't needed. :) Chrome has a macro (arraysize)
that handles this. 

This constant is not used anywhere in Chrome (see
https://code.google.com/p/chromium/codesearch#chromium/src/net/cert/ct_known_...
), so you could just as well remove it. I thought he kept it - and its form -
for potential other consumers, in which case, it seems to make no difference
about hardcoding or not, since it's all generated. Hardcoding makes it ever so
slightly less work for the compiler :P

 
 #endif  // NET_CERT_CT_KNOWN_LOGS_STATIC_H_