Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 1338363003: [MD settings] minor changes to make OnStartup elements line up better (Closed)

Created:
5 years, 3 months ago by dschuyler
Modified:
5 years, 3 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, khorimoto+watch-md-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, jhawkins+watch-md-settings_chromium.org, orenb+watch-md-settings_chromium.org, arv+watch_chromium.org, stevenjb+watch-md-settings_chromium.org, jlklein+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] minor changes to make OnStartup elements line up better This CL puts a little extra space between the list and the buttons. It also makes the items paper-icon-items so they line up better. BUG=531750 Committed: https://crrev.com/d755e4bf5100fa835c8a3d426937aa7dbf9c47f8 Cr-Commit-Position: refs/heads/master@{#348778}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M chrome/browser/resources/settings/on_startup_page/on_startup_shared.css View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/on_startup_page/startup_urls_page.html View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1338363003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1338363003/1
5 years, 3 months ago (2015-09-14 17:40:13 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 3 months ago (2015-09-14 17:40:16 UTC) #5
dschuyler
5 years, 3 months ago (2015-09-14 17:40:27 UTC) #6
michaelpg
lgtm, but can you make a separate bug for the On Startup section?
5 years, 3 months ago (2015-09-14 19:02:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1338363003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1338363003/1
5 years, 3 months ago (2015-09-14 23:28:07 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-15 00:04:47 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d755e4bf5100fa835c8a3d426937aa7dbf9c47f8 Cr-Commit-Position: refs/heads/master@{#348778}
5 years, 3 months ago (2015-09-15 00:05:26 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:39:42 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d755e4bf5100fa835c8a3d426937aa7dbf9c47f8
Cr-Commit-Position: refs/heads/master@{#348778}

Powered by Google App Engine
This is Rietveld 408576698