Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 1338283003: Revert of Move fetching logic out of ApplicationManager, eliminate url mappings. (Closed)

Created:
5 years, 3 months ago by Devlin
Modified:
5 years, 3 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, penghuang+watch-mandoline_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move fetching logic out of ApplicationManager, eliminate url mappings. (patchset #14 id:260001 of https://codereview.chromium.org/1342503003/ ) Reason for revert: Broke the gn builds: ERROR at //mojo/fetcher/about_fetcher_unittest.cc:17:11: Can't include this header from here. #include "mojo/fetcher/about_fetcher.h" ^--------------------------- The target: //mojo/runner:mojo_runner_unittests is including a file from the target: //mojo/fetcher:fetcher It's usually best to depend directly on the destination target. In some cases, the destination target is considered a subcomponent of an intermediate target. In this case, the intermediate target should depend publicly on the destination to forward the ability to include headers. Dependency chain (there may also be others): //mojo/runner:mojo_runner_unittests --> //mojo/runner:lib --[private]--> //mojo/fetcher:fetcher https://build.chromium.org/p/chromium.linux/builders/Linux%20GN/builds/32017/steps/gn_check/logs/stdio Original issue's description: > Move fetching logic out of ApplicationManager, eliminate url mappings. > > BUG= > > Committed: https://crrev.com/7134773ceeef31531b84818158902e6d7c74f110 > Cr-Commit-Position: refs/heads/master@{#348659} > > Committed: https://crrev.com/c7ef4d2131963307ea537fc269bb5acee9383de2 > Cr-Commit-Position: refs/heads/master@{#348954} TBR=sky@chromium.org,yzshen@chromium.org,ben@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/295cbb2e343a6502334110c4d64189df6f2d83fa Cr-Commit-Position: refs/heads/master@{#348979}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1902 lines, -1604 lines) Patch
M components/web_view/test_runner/launcher.cc View 1 chunk +1 line, -4 lines 0 comments Download
M content/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/mojo/mojo_shell_context.h View 2 chunks +10 lines, -2 lines 0 comments Download
M content/browser/mojo/mojo_shell_context.cc View 4 chunks +16 lines, -10 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M mandoline/app/desktop/launcher_process.cc View 2 chunks +1 line, -4 lines 0 comments Download
D mojo/fetcher/BUILD.gn View 1 chunk +0 lines, -44 lines 0 comments Download
D mojo/fetcher/DEPS View 1 chunk +0 lines, -10 lines 0 comments Download
D mojo/fetcher/about_fetcher.h View 1 chunk +0 lines, -58 lines 0 comments Download
D mojo/fetcher/about_fetcher.cc View 1 chunk +0 lines, -111 lines 0 comments Download
D mojo/fetcher/about_fetcher_unittest.cc View 1 chunk +0 lines, -168 lines 0 comments Download
D mojo/fetcher/base_application_fetcher.h View 1 chunk +0 lines, -41 lines 0 comments Download
D mojo/fetcher/base_application_fetcher.cc View 1 chunk +0 lines, -99 lines 0 comments Download
D mojo/fetcher/local_fetcher.h View 1 chunk +0 lines, -58 lines 0 comments Download
D mojo/fetcher/local_fetcher.cc View 1 chunk +0 lines, -116 lines 0 comments Download
D mojo/fetcher/network_fetcher.h View 1 chunk +0 lines, -85 lines 0 comments Download
D mojo/fetcher/network_fetcher.cc View 1 chunk +0 lines, -258 lines 0 comments Download
D mojo/fetcher/switches.h View 1 chunk +0 lines, -16 lines 0 comments Download
D mojo/fetcher/switches.cc View 1 chunk +0 lines, -13 lines 0 comments Download
D mojo/fetcher/update_fetcher.h View 1 chunk +0 lines, -55 lines 0 comments Download
D mojo/fetcher/update_fetcher.cc View 1 chunk +0 lines, -100 lines 0 comments Download
D mojo/fetcher/url_resolver.h View 1 chunk +0 lines, -38 lines 0 comments Download
D mojo/fetcher/url_resolver.cc View 1 chunk +0 lines, -41 lines 0 comments Download
D mojo/fetcher/url_resolver_unittest.cc View 1 chunk +0 lines, -35 lines 0 comments Download
M mojo/mojo_shell.gyp View 2 chunks +7 lines, -31 lines 0 comments Download
M mojo/runner/BUILD.gn View 5 chunks +6 lines, -3 lines 0 comments Download
A mojo/runner/about_fetcher.h View 1 chunk +58 lines, -0 lines 0 comments Download
A mojo/runner/about_fetcher.cc View 1 chunk +111 lines, -0 lines 0 comments Download
A mojo/runner/about_fetcher_unittest.cc View 1 chunk +187 lines, -0 lines 0 comments Download
M mojo/runner/android/main.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/runner/child_process_host_unittest.cc View 2 chunks +1 line, -4 lines 0 comments Download
M mojo/runner/context.h View 5 chunks +35 lines, -6 lines 0 comments Download
M mojo/runner/context.cc View 9 chunks +123 lines, -19 lines 0 comments Download
M mojo/runner/desktop/launcher_process.cc View 2 chunks +1 line, -4 lines 0 comments Download
M mojo/runner/in_process_native_runner_unittest.cc View 2 chunks +1 line, -4 lines 0 comments Download
M mojo/runner/native_runner_unittest.cc View 3 chunks +28 lines, -21 lines 0 comments Download
M mojo/runner/shell_test_base.h View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/runner/shell_test_base.cc View 2 chunks +12 lines, -5 lines 0 comments Download
M mojo/runner/shell_test_base_android.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M mojo/runner/switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/runner/switches.cc View 1 chunk +4 lines, -0 lines 0 comments Download
A mojo/runner/url_resolver.h View 1 chunk +81 lines, -0 lines 0 comments Download
A mojo/runner/url_resolver.cc View 1 chunk +117 lines, -0 lines 0 comments Download
A mojo/runner/url_resolver_unittest.cc View 1 chunk +160 lines, -0 lines 0 comments Download
M mojo/shell/BUILD.gn View 2 chunks +6 lines, -1 line 0 comments Download
M mojo/shell/DEPS View 1 chunk +2 lines, -0 lines 0 comments Download
D mojo/shell/application_fetcher.h View 1 chunk +0 lines, -43 lines 0 comments Download
M mojo/shell/application_manager.h View 9 chunks +33 lines, -6 lines 0 comments Download
M mojo/shell/application_manager.cc View 12 chunks +87 lines, -21 lines 0 comments Download
M mojo/shell/application_manager_unittest.cc View 12 chunks +107 lines, -39 lines 0 comments Download
M mojo/shell/capability_filter_unittest.cc View 5 chunks +22 lines, -22 lines 0 comments Download
A mojo/shell/local_fetcher.h View 1 chunk +59 lines, -0 lines 0 comments Download
A mojo/shell/local_fetcher.cc View 1 chunk +117 lines, -0 lines 0 comments Download
A mojo/shell/network_fetcher.h View 1 chunk +85 lines, -0 lines 0 comments Download
A mojo/shell/network_fetcher.cc View 1 chunk +258 lines, -0 lines 0 comments Download
A mojo/shell/update_fetcher.h View 1 chunk +55 lines, -0 lines 0 comments Download
A mojo/shell/update_fetcher.cc View 1 chunk +101 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Devlin
Created Revert of Move fetching logic out of ApplicationManager, eliminate url mappings.
5 years, 3 months ago (2015-09-15 20:28:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1338283003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1338283003/1
5 years, 3 months ago (2015-09-15 20:28:48 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-15 20:30:36 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/295cbb2e343a6502334110c4d64189df6f2d83fa Cr-Commit-Position: refs/heads/master@{#348979}
5 years, 3 months ago (2015-09-15 20:31:19 UTC) #4
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:48:58 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/295cbb2e343a6502334110c4d64189df6f2d83fa
Cr-Commit-Position: refs/heads/master@{#348979}

Powered by Google App Engine
This is Rietveld 408576698