Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(715)

Issue 1338263002: Fix output directory to use for `claude test`. (Closed)

Created:
5 years, 3 months ago by ppi
Modified:
5 years, 3 months ago
Reviewers:
qsr
CC:
mojo-reviews_chromium.org
Base URL:
https://github.com/domokit/monet.git@master
Target Ref:
refs/heads/master
Project:
monet
Visibility:
Public.

Description

Fix output directory to use for `claude test`. The output directory for `build` is debug by default. `test` should pick its target directory the same way as `build` instead of hard-coding Release. R=qsr@chromium.org Committed: https://github.com/domokit/monetbdf487d14d8c79eedc62ccd709cd59b08284ddad

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M claude.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
ppi
Hi Ben, ptal.
5 years, 3 months ago (2015-09-14 11:59:44 UTC) #1
qsr
lgtm
5 years, 3 months ago (2015-09-14 12:19:16 UTC) #2
ppi
5 years, 3 months ago (2015-09-14 12:20:39 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bdf487d14d8c79eedc62ccd709cd59b08284ddad (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698