Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 1338253002: [loggers] Guard object/code move events using mutexes. (Closed)

Created:
5 years, 3 months ago by Michael Lippautz
Modified:
5 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[loggers] Guard object/code move events using mutexes. Parallel compaction, i.e., concurrently moving of objects (and code) requires proper synchronization in the logger. R=hpayer@chromium.org BUG=chromium:524425 LOG=N Committed: https://crrev.com/8f403270670d03d86fc3ba49067e24287edd0d2c Cr-Commit-Position: refs/heads/master@{#30714}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M src/heap-profiler.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/heap-profiler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/log.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Lippautz
The first trivial spinoff from https://codereview.chromium.org/1330463002/ (prototype) Parallel compaction requires concurrent logging of object and ...
5 years, 3 months ago (2015-09-14 10:44:50 UTC) #2
Hannes Payer (out of office)
lgtm
5 years, 3 months ago (2015-09-14 11:34:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1338253002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1338253002/1
5 years, 3 months ago (2015-09-14 11:41:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-14 12:06:46 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-14 12:07:00 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8f403270670d03d86fc3ba49067e24287edd0d2c
Cr-Commit-Position: refs/heads/master@{#30714}

Powered by Google App Engine
This is Rietveld 408576698