Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(692)

Issue 1338193003: Remove webkit dependency in grit_rule. (Closed)

Created:
5 years, 3 months ago by Dirk Pranke
Modified:
5 years, 3 months ago
Reviewers:
brettw, Raymond Toy
CC:
brettw, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove webkit dependency in grit_rule. We needed to set a grit define to build the blink_resources target properly. We were doing this via a global define that affected all targets, but now we're doing this with a local define instead. R=rtoy@chromium.org BUG= Committed: https://crrev.com/4be705ba5d1d13fbb1c5d2f4f578273f13ed632c Cr-Commit-Position: refs/heads/master@{#348812}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M build/secondary/tools/grit/grit_rule.gni View 2 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Dirk Pranke
This patch depends on a blink-side CL landing first: https://codereview.chromium.org/1338993008/ and rolling into chromium before ...
5 years, 3 months ago (2015-09-14 22:33:11 UTC) #1
brettw
lgtm
5 years, 3 months ago (2015-09-14 22:53:53 UTC) #3
Raymond Toy
lgtm
5 years, 3 months ago (2015-09-14 22:55:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1338193003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1338193003/1
5 years, 3 months ago (2015-09-15 00:58:41 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-15 01:45:46 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4be705ba5d1d13fbb1c5d2f4f578273f13ed632c Cr-Commit-Position: refs/heads/master@{#348812}
5 years, 3 months ago (2015-09-15 01:46:38 UTC) #8
kjellander_chromium
On 2015/09/15 01:46:38, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as ...
5 years, 3 months ago (2015-09-15 06:15:23 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:41:17 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4be705ba5d1d13fbb1c5d2f4f578273f13ed632c
Cr-Commit-Position: refs/heads/master@{#348812}

Powered by Google App Engine
This is Rietveld 408576698