Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 1338193002: Reduce allocation size of FormData::m_entries. (Closed)

Created:
5 years, 3 months ago by tkent
Modified:
5 years, 3 months ago
Reviewers:
keishi
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Reduce allocation size of FormData::m_entries. Store Entry objects as pointers instead of inline objects. This reduces the size of unused slots in m_entries Vector. Also, FormData::Entry no longer need to support copy operations. It's immutable now. This CL has no user-visible behavior changes. BUG=528840 R=keishi@chromium.org Committed: https://crrev.com/4f4e4604d866331ae8c6ce04becf81fe10b3ae34 git-svn-id: svn://svn.chromium.org/blink/trunk@202172 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -57 lines) Patch
M Source/core/html/FormData.h View 3 chunks +10 lines, -11 lines 0 comments Download
M Source/core/html/FormData.cpp View 11 chunks +43 lines, -42 lines 0 comments Download
M Source/core/html/FormDataTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/WebSearchableFormData.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
tkent
Keishi, please review this.
5 years, 3 months ago (2015-09-14 01:27:44 UTC) #3
keishi
LGTM
5 years, 3 months ago (2015-09-14 02:36:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1338193002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1338193002/20001
5 years, 3 months ago (2015-09-14 03:07:32 UTC) #6
tkent
Committed patchset #1 (id:20001) manually as 202172 (presubmit successful).
5 years, 3 months ago (2015-09-14 04:22:27 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:28:56 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4f4e4604d866331ae8c6ce04becf81fe10b3ae34

Powered by Google App Engine
This is Rietveld 408576698