Add a completion for inherited methods

Add a completion for inherited methods

R=danrubel@google.com

Committed: https://github.com/dart-lang/sdk/commit/f4b1879180063c5a3166422d16b050a10f027b7b

[Brian Wilkerson, 2015-09-13 15:38:31]

brianwilkerson@google.com changed reviewers:
+ danrubel@google.com

[Brian Wilkerson, 2015-09-13 15:38:32]

These tests pass, and I wrote an integration test (not included) to test the
whole process from CompletionManager.results, but I was not successful in
getting the new completions from a running client. It's possible that
- I'm not running the newly built server like I think I am,
- the results I'm producing are invalid for the client, or
- that there's something else wrong with this code.
Please look it over carefully; I could really use your help.

[danrubel, 2015-09-18 00:30:54]

LGTM with suggestions.

https://codereview.chromium.org/1338173002/diff/1/pkg/analysis_server/lib/src...
File
pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart
(right):

https://codereview.chromium.org/1338173002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart:101:
new NewCompletionWrapper(new InheritedContributor())
Please comment this line out for now and commit the changes. We'll review and
fix in a subsequent CL.

https://codereview.chromium.org/1338173002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart:444:
}
return true after this for loop

https://codereview.chromium.org/1338173002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart:446:
return true;
return false here

https://codereview.chromium.org/1338173002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/services/completion/inherited_computer.dart
(right):

https://codereview.chromium.org/1338173002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/inherited_computer.dart:25:
class InheritedContributor extends DartCompletionContributor {
Nit: rename file inherited_computer --> interited_contributor

[Brian Wilkerson, 2015-09-18 15:59:26]

https://codereview.chromium.org/1338173002/diff/1/pkg/analysis_server/lib/src...
File
pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart
(right):

https://codereview.chromium.org/1338173002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart:101:
new NewCompletionWrapper(new InheritedContributor())
Done

https://codereview.chromium.org/1338173002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart:444:
}
Done

https://codereview.chromium.org/1338173002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart:446:
return true;
Done

https://codereview.chromium.org/1338173002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/services/completion/inherited_computer.dart
(right):

https://codereview.chromium.org/1338173002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/inherited_computer.dart:25:
class InheritedContributor extends DartCompletionContributor {
Done

[Brian Wilkerson, 2015-09-18 16:00:01]

Committed patchset #1 (id:1) manually as
f4b1879180063c5a3166422d16b050a10f027b7b (presubmit successful).